Bound the size of cache in deprecation logger #16722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the map used to de-duplicate deprecation log messages can grow without bound. This replaces the ConcurrentHashMap implementation with an `o.o.common.cache.Cache` implementation configured for a fixed maximum size. To reduce memory overhead, this also changes to storing only a hash of the key instead of the full text since we never need to retrieve the original entry. Signed-off-by: Andrew Ross <[email protected]>
andrross
requested review from
anasalkouz,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 83514e1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Accidentally pushed this dev branch to the wrong repo. Will open a corrected PR against my user fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the map used to de-duplicate deprecation log messages can grow without bound. This replaces the ConcurrentHashMap implementation with an
o.o.common.cache.Cacheimplementation configured for a fixed maximum size. To reduce memory overhead, this also changes to storing only a hash of the key instead of the full text since we never need to retrieve the original entry.Related Issues
Resolves #16702
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.