-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version check in yml test file for double range profiler shows filter rewrite info #16125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lter rewrite info Signed-off-by: Gao Binlong <[email protected]>
gaobinlong
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
September 30, 2024 02:11
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16125 +/- ##
============================================
+ Coverage 71.94% 71.96% +0.02%
- Complexity 64439 64447 +8
============================================
Files 5281 5281
Lines 301228 301228
Branches 43519 43519
============================================
+ Hits 216705 216775 +70
+ Misses 66708 66643 -65
+ Partials 17815 17810 -5 ☔ View full report in Codecov by Sentry. |
reta
approved these changes
Sep 30, 2024
Thanks @gaobinlong ! |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…lter rewrite info (#16125) Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit e6e290d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Sep 30, 2024
…lter rewrite info (#16125) (#16131) (cherry picked from commit e6e290d) Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hainenber
pushed a commit
to hainenber/OpenSearch
that referenced
this pull request
Oct 1, 2024
…lter rewrite info (opensearch-project#16125) Signed-off-by: Gao Binlong <[email protected]>
ruai0511
pushed a commit
to ruai0511/OpenSearch
that referenced
this pull request
Oct 4, 2024
…lter rewrite info (opensearch-project#16125) Signed-off-by: Gao Binlong <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…lter rewrite info (opensearch-project#16125) Signed-off-by: Gao Binlong <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…lter rewrite info (opensearch-project#16125) Signed-off-by: Gao Binlong <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…lter rewrite info (opensearch-project#16125) Signed-off-by: Gao Binlong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up PR of #13865, which added filter rewrite info for the double range profiler, we need to update the version check in yaml test file to 2.16.0 because the original PR was released in 2.16.0.
Backport to 2.x is needed.
Related Issues
No issue.
Check List
- [ ] Functionality includes testing.
- [ ] API changes companion pull request created, if applicable.
- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.