Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support scripting for composite aggs in concurrent segment search #15094

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Aug 2, 2024

Description

Backport #15072

Check List

  • Functionality includes testing.
    - [] API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jed326
Copy link
Collaborator Author

jed326 commented Aug 2, 2024

Might be easier to wait for #15093 to get merged first actually

Copy link
Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for cbf3396: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 1495aca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jed326 jed326 added the v2.17.0 label Aug 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 9aaf32e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Aug 2, 2024

✅ Gradle check result for 8aa8fcd: SUCCESS

Copy link
Contributor

github-actions bot commented Aug 2, 2024

❕ Gradle check result for 0e04531: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.57%. Comparing base (e03e093) to head (0e04531).

Files Patch % Lines
.../bucket/composite/CompositeAggregationFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15094      +/-   ##
============================================
- Coverage     71.71%   71.57%   -0.14%     
+ Complexity    62868    62755     -113     
============================================
  Files          5125     5125              
  Lines        294586   294588       +2     
  Branches      42934    42934              
============================================
- Hits         211260   210855     -405     
- Misses        65600    66034     +434     
+ Partials      17726    17699      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jed326
Copy link
Collaborator Author

jed326 commented Aug 2, 2024

@reta could you approve this again? Thanks!

@jed326 jed326 merged commit 4fad470 into opensearch-project:2.x Aug 2, 2024
35 checks passed
@jed326 jed326 deleted the backport-15072 branch August 7, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants