Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix constant_keyword field type not working #14651

Closed
wants to merge 1 commit into from
Closed

fix constant_keyword field type not working #14651

wants to merge 1 commit into from

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Jul 4, 2024 •
edited
Loading

Description

Fix constant_keyword field type not working

Related Issues

Resolves #14638

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing labels Jul 4, 2024
@kkewwei kkewwei force-pushed the fix_constant_keyword branch 2 times, most recently from 4abd9ae to 04e4352 Compare July 4, 2024 12:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

❌ Gradle check result for 4abd9ae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

❌ Gradle check result for 157063f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

✅ Gradle check result for 04e4352: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.77%. Comparing base (74230b7) to head (490132a).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #14651      +/-   ##
============================================
+ Coverage     71.73%   71.77%   +0.04%     
- Complexity    62317    62332      +15     
============================================
  Files          5140     5140              
  Lines        293025   293026       +1     
  Branches      42347    42347              
============================================
+ Hits         210198   210323     +125     
+ Misses        65509    65322     -187     
- Partials      17318    17381      +63

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gaobinlong
gaobinlong reviewed Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@gaobinlong gaobinlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we don't have yaml test cases for the constant_keyword type, could you add some yaml test cases for this bug fix?

@kkewwei
Copy link
Contributor Author

kkewwei commented Jul 5, 2024

Seems we don't have yaml test cases for the constant_keyword type, could you add some yaml test cases for this bug fix?

sure.

@kkewwei kkewwei force-pushed the fix_constant_keyword branch 2 times, most recently from 0096b12 to 989979a Compare July 10, 2024 01:12
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0096b12: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 989979a:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Jul 10, 2024

Can someone also add this field to https://github.com/opensearch-project/opensearch-api-specification?

@dblock, I will have a try later.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for daa4cbb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the fix_constant_keyword branch 2 times, most recently from 68c1b9f to 1b4b111 Compare July 15, 2024 04:02
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 68c1b9f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1b4b111: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ccd4794: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the fix_constant_keyword branch from ccd4794 to 820da72 Compare July 15, 2024 14:06
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 820da72: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the fix_constant_keyword branch from 820da72 to b34f5af Compare July 17, 2024 02:43
@kkewwei kkewwei mentioned this pull request Jul 17, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b34f5af: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the fix_constant_keyword branch from b34f5af to 1d94d6e Compare July 17, 2024 03:35
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1d94d6e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Jul 17, 2024 •
edited
Loading

@dblock help please.

ci throws error.
image
https://build.ci.opensearch.org/blue/organizations/jenkins/gradle-check/detail/gradle-check/42574/pipeline

I have fixed it, but it still throw the exception.
image

@dblock dblock mentioned this pull request Jul 17, 2024
Merged
@kkewwei
Copy link
Contributor Author

kkewwei commented Jul 17, 2024 •
edited
Loading

If i should open a new pr to replace this one?

@kkewwei kkewwei deleted the fix_constant_keyword branch July 24, 2024 06:55
This was referenced Sep 6, 2024
Open
Open
Open
Open
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaobinlong gaobinlong gaobinlong left review comments

@dblock dblock dblock requested changes

@vikasvb90 vikasvb90 vikasvb90 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@kkewwei kkewwei

Labels
backport 2.x Backport to 2.x branch bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Constant keyword field type not working - index created in a defect state
4 participants
@kkewwei @dblock @gaobinlong @vikasvb90