Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to iterative version of WKT format parser #14086

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

heemin32
Copy link
Contributor

@heemin32 heemin32 commented Jun 8, 2024

Description

Switch to iterative version of WKT format parser

Related Issues

N/A

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for 9a429ef: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for 24305a5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 8, 2024

✅ Gradle check result for 1ef63ad: SUCCESS

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.77%. Comparing base (b15cb0c) to head (a8aef7d).
Report is 446 commits behind head on main.

Files Patch % Lines
...a/org/opensearch/geometry/utils/WellKnownText.java 93.93% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14086      +/-   ##
============================================
+ Coverage     71.42%   71.77%   +0.35%     
- Complexity    59978    62159    +2181     
============================================
  Files          4985     5118     +133     
  Lines        282275   291877    +9602     
  Branches      40946    42189    +1243     
============================================
+ Hits         201603   209500    +7897     
- Misses        63999    65123    +1124     
- Partials      16673    17254     +581     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 920c417: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@heemin32
Copy link
Contributor Author

Copy link
Contributor

❌ Gradle check result for 920c417: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 47ce156: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419
Copy link
Contributor

LGTM, can you please resolve conflicts and lets wait for CI to succeed. I guess there are some ongoing flaky tests.

Copy link
Contributor

❕ Gradle check result for a8aef7d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@heemin32 heemin32 requested a review from sandeshkr419 June 18, 2024 17:28
@msfroh msfroh merged commit 120678d into opensearch-project:main Jun 18, 2024
32 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 18, 2024
Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit 120678d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh pushed a commit that referenced this pull request Jun 18, 2024
(cherry picked from commit 120678d)

Signed-off-by: Heemin Kim <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…14086) (opensearch-project#14431)

(cherry picked from commit 120678d)

Signed-off-by: Heemin Kim <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants