Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing methods for EncryptedBlobStore and EncryptedBlobContainer #14030

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

skumawat2025
Copy link
Contributor

@skumawat2025 skumawat2025 commented Jun 6, 2024

Description

Implement missing methods IsBlobMetadataEnabled(), readBlobWithMetadata() for EncryptedBlobStore and EncryptedBlobContainer. These methods were introduced as part of #13091

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 1be954e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 force-pushed the encrypted-blob-store branch from 1be954e to 9e924dc Compare June 6, 2024 09:01
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 9e924dc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 force-pushed the encrypted-blob-store branch from 9e924dc to 9c4ac19 Compare June 6, 2024 10:32
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 9c4ac19: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 force-pushed the encrypted-blob-store branch from 9c4ac19 to 84b523e Compare June 6, 2024 11:36
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 84b523e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 force-pushed the encrypted-blob-store branch from 84b523e to a1b612b Compare June 6, 2024 12:30
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❕ Gradle check result for a1b612b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.63%. Comparing base (b15cb0c) to head (60f4594).
Report is 374 commits behind head on main.

Files Patch % Lines
...pensearch/common/blobstore/EncryptedBlobStore.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14030      +/-   ##
============================================
+ Coverage     71.42%   71.63%   +0.20%     
- Complexity    59978    61395    +1417     
============================================
  Files          4985     5071      +86     
  Lines        282275   288407    +6132     
  Branches      40946    41764     +818     
============================================
+ Hits         201603   206586    +4983     
- Misses        63999    64767     +768     
- Partials      16673    17054     +381     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we see if we can add UTs atleast for this change?

Copy link
Contributor

❌ Gradle check result for 3233952: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 force-pushed the encrypted-blob-store branch from 3233952 to 54147fd Compare June 10, 2024 01:44
Copy link
Contributor

❌ Gradle check result for 54147fd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 force-pushed the encrypted-blob-store branch from 54147fd to 83035db Compare June 10, 2024 02:36
Copy link
Contributor

❌ Gradle check result for 83035db: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sandeep Kumawat <[email protected]>
@skumawat2025 skumawat2025 force-pushed the encrypted-blob-store branch from 83035db to 60f4594 Compare June 10, 2024 03:40
Copy link
Contributor

✅ Gradle check result for 60f4594: SUCCESS

Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the tests.

@skumawat2025 skumawat2025 marked this pull request as ready for review June 10, 2024 04:39
@gbbafna gbbafna merged commit 270054c into opensearch-project:main Jun 10, 2024
58 of 59 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 10, 2024
…tainer (#14030)

Signed-off-by: Sandeep Kumawat <[email protected]>
(cherry picked from commit 270054c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Jun 10, 2024
…tainer (#14030) (#14114)

(cherry picked from commit 270054c)

Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
@skumawat2025 skumawat2025 added the v2.15.0 Issues and PRs related to version 2.15.0 label Jun 11, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…tainer (opensearch-project#14030) (opensearch-project#14114)

(cherry picked from commit 270054c)

Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog v2.15.0 Issues and PRs related to version 2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants