COMPAT locale provider will be removed in a future release #13988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolarkunnu
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
github-actions
bot
added
Build
akolarkunnu
force-pushed
the
localeprovider2
branch
3 times, most recently
from
ace314c to
6ca1ba4
Compare
Description: From JDK21 onwards a new warning has started to come, "WARNING: COMPAT locale provider will be removed in a future release". So, we have to avoid usage of COMPAT provider. We were setting exlpicitly to COMPAT locale provider in couple of places, this change is to convert COMPAT to CLDR locale provider. After this change, couple of tests started to fail becasue some locale data has minor changes in CLDR compared to COMPAT. For example, day and month short names of GERMAN "de" locale are different in CLDR and COMPAT, just need to add a . in the end for CLDR. Resolves opensearch-project#11550 Signed-off-by: Muneer Kolarkunnu <[email protected]> Signed-off-by: akolarkunnu <[email protected]>
akolarkunnu
force-pushed
the
localeprovider2
branch
from
6ca1ba4 to
06b0fa6
Compare
|
❌ Gradle check result for c111166: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
approved these changes
Jun 5, 2024
|
Just to note, did a number of test runs, seems to be no flakyness introduced by this change |
LantaoJin
pushed a commit
to LantaoJin/OpenSearch
that referenced
this pull request
Jun 6, 2024
…h-project#13988) * COMPAT locale provider will be removed in a future release Description: From JDK21 onwards a new warning has started to come, "WARNING: COMPAT locale provider will be removed in a future release". So, we have to avoid usage of COMPAT provider. We were setting exlpicitly to COMPAT locale provider in couple of places, this change is to convert COMPAT to CLDR locale provider. After this change, couple of tests started to fail becasue some locale data has minor changes in CLDR compared to COMPAT. For example, day and month short names of GERMAN "de" locale are different in CLDR and COMPAT, just need to add a . in the end for CLDR. Resolves opensearch-project#11550 Signed-off-by: Muneer Kolarkunnu <[email protected]> Signed-off-by: akolarkunnu <[email protected]> * COMPAT locale provider will be removed in a future release Description: From JDK21 onwards a new warning has started to come, "WARNING: COMPAT locale provider will be removed in a future release". So, we have to avoid usage of COMPAT provider. We were setting exlpicitly to COMPAT locale provider in couple of places, this change is to convert COMPAT to CLDR locale provider. After this change, couple of tests started to fail becasue some locale data has minor changes in CLDR compared to COMPAT. For example, day and month short names of GERMAN "de" locale are different in CLDR and COMPAT, just need to add a . in the end for CLDR. Resolves opensearch-project#11550 Signed-off-by: Abdul Muneer Kolarkunnu [email protected] Signed-off-by: akolarkunnu <[email protected]> --------- Signed-off-by: Muneer Kolarkunnu <[email protected]> Signed-off-by: akolarkunnu <[email protected]> Signed-off-by: Abdul Muneer Kolarkunnu [email protected] Co-authored-by: akolarkunnu <[email protected]>
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
Jun 6, 2024
…pensearch-project#13988)" This reverts commit ba0df74. Signed-off-by: Andriy Redko <[email protected]>
3 tasks
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
Jun 6, 2024
reta
added a commit
that referenced
this pull request
Jun 6, 2024
…13988)" (#14039) This reverts commit ba0df74. Signed-off-by: Andriy Redko <[email protected]>
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
…h-project#13988) * COMPAT locale provider will be removed in a future release Description: From JDK21 onwards a new warning has started to come, "WARNING: COMPAT locale provider will be removed in a future release". So, we have to avoid usage of COMPAT provider. We were setting exlpicitly to COMPAT locale provider in couple of places, this change is to convert COMPAT to CLDR locale provider. After this change, couple of tests started to fail becasue some locale data has minor changes in CLDR compared to COMPAT. For example, day and month short names of GERMAN "de" locale are different in CLDR and COMPAT, just need to add a . in the end for CLDR. Resolves opensearch-project#11550 Signed-off-by: Muneer Kolarkunnu <[email protected]> Signed-off-by: akolarkunnu <[email protected]> * COMPAT locale provider will be removed in a future release Description: From JDK21 onwards a new warning has started to come, "WARNING: COMPAT locale provider will be removed in a future release". So, we have to avoid usage of COMPAT provider. We were setting exlpicitly to COMPAT locale provider in couple of places, this change is to convert COMPAT to CLDR locale provider. After this change, couple of tests started to fail becasue some locale data has minor changes in CLDR compared to COMPAT. For example, day and month short names of GERMAN "de" locale are different in CLDR and COMPAT, just need to add a . in the end for CLDR. Resolves opensearch-project#11550 Signed-off-by: Abdul Muneer Kolarkunnu [email protected] Signed-off-by: akolarkunnu <[email protected]> --------- Signed-off-by: Muneer Kolarkunnu <[email protected]> Signed-off-by: akolarkunnu <[email protected]> Signed-off-by: Abdul Muneer Kolarkunnu [email protected] Co-authored-by: akolarkunnu <[email protected]>
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
…pensearch-project#13988)" (opensearch-project#14039) This reverts commit ba0df74. Signed-off-by: Andriy Redko <[email protected]>
This was referenced Jun 13, 2024
3 tasks
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…h-project#13988) * COMPAT locale provider will be removed in a future release Description: From JDK21 onwards a new warning has started to come, "WARNING: COMPAT locale provider will be removed in a future release". So, we have to avoid usage of COMPAT provider. We were setting exlpicitly to COMPAT locale provider in couple of places, this change is to convert COMPAT to CLDR locale provider. After this change, couple of tests started to fail becasue some locale data has minor changes in CLDR compared to COMPAT. For example, day and month short names of GERMAN "de" locale are different in CLDR and COMPAT, just need to add a . in the end for CLDR. Resolves opensearch-project#11550 Signed-off-by: Muneer Kolarkunnu <[email protected]> Signed-off-by: akolarkunnu <[email protected]> * COMPAT locale provider will be removed in a future release Description: From JDK21 onwards a new warning has started to come, "WARNING: COMPAT locale provider will be removed in a future release". So, we have to avoid usage of COMPAT provider. We were setting exlpicitly to COMPAT locale provider in couple of places, this change is to convert COMPAT to CLDR locale provider. After this change, couple of tests started to fail becasue some locale data has minor changes in CLDR compared to COMPAT. For example, day and month short names of GERMAN "de" locale are different in CLDR and COMPAT, just need to add a . in the end for CLDR. Resolves opensearch-project#11550 Signed-off-by: Abdul Muneer Kolarkunnu [email protected] Signed-off-by: akolarkunnu <[email protected]> --------- Signed-off-by: Muneer Kolarkunnu <[email protected]> Signed-off-by: akolarkunnu <[email protected]> Signed-off-by: Abdul Muneer Kolarkunnu [email protected] Co-authored-by: akolarkunnu <[email protected]>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…pensearch-project#13988)" (opensearch-project#14039) This reverts commit ba0df74. Signed-off-by: Andriy Redko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From JDK21 onwards a new warning has started to come, "WARNING: COMPAT locale provider will be removed in a future release". So, we have to avoid usage of COMPAT provider. We were setting exlpicitly to COMPAT locale provider in couple of places, this change is to convert COMPAT to CLDR locale provider. After this change, couple of tests started to fail becasue some locale data has minor changes in CLDR compared to COMPAT. For example, day and month short names of GERMAN "de" locale are different in CLDR and COMPAT, just need to add a . in the end for CLDR.
Related Issues
Resolves #11550
Signed-off-by: Muneer Kolarkunnu [email protected]
Check List
New functionality includes testing.New functionality has been documented.New functionality has javadoc addedAPI changes companion pull request created.Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.