-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jay Deng as a maintainer #13773
Add Jay Deng as a maintainer #13773
Conversation
Signed-off-by: Sorabh Hamirwasia <[email protected]>
❕ Gradle check result for 40d45fe: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13773 +/- ##
============================================
+ Coverage 71.42% 71.60% +0.18%
- Complexity 59978 61231 +1253
============================================
Files 4985 5062 +77
Lines 282275 287905 +5630
Branches 40946 41692 +746
============================================
+ Hits 201603 206155 +4552
- Misses 63999 64691 +692
- Partials 16673 17059 +386 ☔ View full report in Codecov by Sentry. |
Known issue: #10983 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well deserved @jed326 !
Added @jed326 as maintainer. |
Signed-off-by: Sorabh Hamirwasia <[email protected]> (cherry picked from commit 199a03e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 199a03e) Signed-off-by: Sorabh Hamirwasia <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sorabh Hamirwasia <[email protected]>
…roject#13774) (cherry picked from commit 199a03e) Signed-off-by: Sorabh Hamirwasia <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
Description
Jay has accepted the invitation to become a maintainer. Welcome Jay!
Jay is an active contributor of OpenSearch project and has extensively contributed in the concurrent segment search feature to make it GA for the users. Aside from this he proactively contributed to improve the documentations for different aggregations like term, sampler, diversified sampler, etc based on his learnings and is pretty active in the triage meetings and reviewing issues/PRs. Jay has contributed 56 pull requests to the project and reviewed close to 53 PRs. Some of his main contributions are:
PRs:
Enabling parallel buildAggregation with concurrent search to further improve on agg performance [Concurrent Segment Search] Perform buildAggregation in parallel #11673
Doc count error computation at slice level: [Concurrent Segment Search] Doc count error needs to be computed at the slice level #11680
New index_searcher threadpool and integrate it with Resource tracking framework. [Concurrent Segment Search]: Design/Prototype changes for TaskResourceTrackingFramework and SearchBackpressure with concurrent search #7425
New metrics related to concurrent search and wait time for search related threadpools.
** Adding concurrent search versions of query count/time metrics #9622
** Add threadpool wait time metric #9681
Dynamic way to enable/disable concurrent search. Followed by mechanism in the AggregationFactory to separate aggregations which supports concurrent search and determine at runtime if requests needs to be executed using concurrent vs non-concurrent path
** Add dynamic index and cluster setting for concurrent segment search #7956
** Update AggregatorFactory to provide a method to indicate if it supports concurrent search #9469
Issues:
Deep Dives:
Evaluation to support force termination with terminate_after in concurrent search path #8371
Evaluation for Parent Join agg and Diversified Sampler for concurrent search support: #9316, #11075
The maintainers have voted and agreed to this nomination, following the process here.
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedAPI changes companion pull request created.Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.