[Backport 2.x] Allow doc value search on unindexed boolean and date fields #13514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Making fields searchable Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding tests for boolean fields Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Added tests for date fields Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Updating termsQuery logic Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Spotless Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Updating terms test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Spotless Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Ensure that the points are intersecting for doc_values Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Spotless Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding missing javadocs Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding more tests for indexedValueForSearch Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding MatchAllDocsQuery to asserts Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix changelog Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Simplify loop criteria + remove IndexOrDocValuesQuery Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Add some comments Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix indendation Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fixing boolean field tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Revert to correct logic for termsQuery Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update terms logic to be more succinct Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix terms test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding tests for boolean range query + fix range query to use term query inside Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Checking if upper and lower terms are valid Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Checking if upper and lower terms are valid Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fixing changelog Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> (cherry picked from commit dc77c46) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
VachaShah
approved these changes
May 2, 2024
|
❌ Gradle check result for b23425b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
|
❕ Gradle check result for b23425b: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
@harshavamsi You can add the backport for #13517 in here as well since its a followup of this and needs a manual backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport dc77c46 from #11650.