Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x][Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold … #13413

Merged
merged 10 commits into from
Apr 29, 2024
Merged

[Backport 2.x][Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold … #13413

merged 10 commits into from
Apr 29, 2024

Conversation

kiranprakash154
Copy link
Contributor

@kiranprakash154 kiranprakash154 commented Apr 26, 2024 •
edited
Loading

Backport f798497 from #12941

@kiranprakash154
[Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold …
e3880e1 
…setting dynamic (opensearch-project#12941)

* Update IndicesRequestCache.java

Signed-off-by: Kiran Prakash <[email protected]>

* Update ClusterSettings.java

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

* spotless

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

* some refactoring

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCache.java

Signed-off-by: Kiran Prakash <[email protected]>

* address existing tests

Signed-off-by: Kiran Prakash <[email protected]>

* UTs

Signed-off-by: Kiran Prakash <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Kiran Prakash <[email protected]>

* ITs

Signed-off-by: Kiran Prakash <[email protected]>

* spotless

Signed-off-by: Kiran Prakash <[email protected]>

* refactor

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Kiran Prakash <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCache.java

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

* resolve conflicts

Signed-off-by: Kiran Prakash <[email protected]>

* address code comments

Signed-off-by: Kiran Prakash <[email protected]>

* address code comments

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

* rename tests

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

* resolve conflicts

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCache.java

Signed-off-by: Kiran Prakash <[email protected]>

* code comments

Signed-off-by: Kiran Prakash <[email protected]>

* Update IndicesRequestCacheIT.java

Signed-off-by: Kiran Prakash <[email protected]>

---------

Signed-off-by: Kiran Prakash <[email protected]>
(cherry picked from commit f798497)
@kiranprakash154
resolve conflicts
b7a70d0 
Signed-off-by: Kiran Prakash <[email protected]>
@kiranprakash154
Merge branch '2.x' into backport/backport-12941-to-2.x
735a25d 
Signed-off-by: Kiran Prakash <[email protected]>
@kiranprakash154
remove typo
0e7d692 
Signed-off-by: Kiran Prakash <[email protected]>
@kiranprakash154 kiranprakash154 changed the title [Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold … [Backport 2.x][Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold … Apr 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 735a25d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b7a70d0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 0e7d692: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Apr 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 71.17%. Comparing base (0dd892c) to head (7d3f1ef).
Report is 201 commits behind head on 2.x.

Files Patch % Lines
...va/org/opensearch/indices/IndicesRequestCache.java 62.50% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #13413      +/-   ##
============================================
- Coverage     71.28%   71.17%   -0.12%     
- Complexity    60145    60697     +552     
============================================
  Files          4957     5015      +58     
  Lines        282799   286025    +3226     
  Branches      41409    41797     +388     
============================================
+ Hits         201591   203568    +1977     
- Misses        64189    65195    +1006     
- Partials      17019    17262     +243

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiranprakash154 kiranprakash154 marked this pull request as ready for review April 26, 2024 20:46
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 163d8f9: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 9592cd3: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d9d36cd: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for fe77207: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for eb02b2f: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 7d3f1ef: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadBlobWithRetries

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@kiranprakash154 kiranprakash154 mentioned this pull request Apr 28, 2024
Closed
@kiranprakash154
Copy link
Contributor Author

❕ Gradle check result for 7d3f1ef: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadBlobWithRetries

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Created this issue for flakiness
#13433

@kiranprakash154
Copy link
Contributor Author

@sohami can u help merge this ?
(cc: @sgup432 @kkhatua )

@kiranprakash154 kiranprakash154 self-assigned this Apr 29, 2024
@sohami sohami merged commit a2cf155 into opensearch-project:2.x Apr 29, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohami sohami sohami approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@kiranprakash154 kiranprakash154

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiranprakash154 @sohami