Add SearchRequest deep cocpy functionality #1338
Conversation
Signed-off-by: Daichi Nuki <[email protected]>
|
Can one of the admins verify this patch? |
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Wrapper Validation success 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Wrapper Validation success 67b8f8e |
1 similar comment
|
✅ Gradle Wrapper Validation success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Wrapper Validation success 67b8f8e |
1 similar comment
|
✅ Gradle Wrapper Validation success 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
3 similar comments
|
✅ Gradle Precommit success 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Wrapper Validation success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
|
✅ Gradle Wrapper Validation success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
|
✅ Gradle Wrapper Validation success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
1 similar comment
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Wrapper Validation success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Wrapper Validation success 67b8f8e |
1 similar comment
|
✅ Gradle Wrapper Validation success 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
1 similar comment
|
✅ Gradle Precommit success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
1 similar comment
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Wrapper Validation success 67b8f8e |
1 similar comment
|
✅ Gradle Wrapper Validation success 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
|
Thanks @Da-1kun does and deserializing the same back doesn't work as a deep copy? Is that too costly?Alternatively you could do a SearchRequest#clone and use corresponding setters for indices and types to set a clone of those types? I noted the copy ctor is already taken to do a shallow copy. That might need to be overloaded |
tlfeng
added
enhancement
|
✅ Gradle Wrapper Validation success 67b8f8e |
|
✅ DCO Check Passed 67b8f8e |
|
✅ Gradle Precommit success 67b8f8e |
|
@Da-1kun Did you not want to move forward with this? |
Signed-off-by: Daichi Nuki [email protected]
Description
Add SearchRequest deep cocpy functionality
Issues Resolved
[List any issues this PR will resolve]
Deep copy for QueryBuilder/SearchRequest #869
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.