Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix org.opensearch.common.xcontent.XContentParserTests.testString flaky test #13164

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Apr 11, 2024

Description

[BUG] Fix org.opensearch.common.xcontent.XContentParserTests.testString flaky test (YAML codepoint calculation is unreliable).

Related Issues

Closes #12395

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the Other label Apr 11, 2024
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 638d8cc

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

✅ Gradle check result for 638d8cc: SUCCESS

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.45%. Comparing base (b15cb0c) to head (638d8cc).
Report is 152 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13164      +/-   ##
============================================
+ Coverage     71.42%   71.45%   +0.03%     
- Complexity    59978    60518     +540     
============================================
  Files          4985     5033      +48     
  Lines        282275   284903    +2628     
  Branches      40946    41286     +340     
============================================
+ Hits         201603   203578    +1975     
- Misses        63999    64446     +447     
- Partials      16673    16879     +206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross added the backport 2.x Backport to 2.x branch label Apr 11, 2024
@andrross andrross merged commit 5d939b9 into opensearch-project:main Apr 11, 2024
83 of 84 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 11, 2024
…ng flaky test (#13164)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 5d939b9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Apr 11, 2024
…ng flaky test (#13164) (#13165)

(cherry picked from commit 5d939b9)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run Other skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.common.xcontent.XContentParserTests.testString is flaky
2 participants