Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement interface changes for s3 plugin to read/write blob with obj… #13113

Merged

Conversation

skumawat2025
Copy link
Contributor

@skumawat2025 skumawat2025 commented Apr 8, 2024

…ect metadata

Description

This PR is a sub task of feature request #13022. And is being tracked here #13091.

This PR implement interfaces changes for s3 plugin introduced as part of PR #13023 to read/write blob object with object metadata.

This PR includes changes for following flows -

  1. async upload flow. (function - asyncBlobUpload()) (currently in use for translog/segments upload in s3 plugin)
  2. sync upload flow. (function - writeBlobAtomic()) (currently in use for other blob stores Azure, GCP)
  3. sync download flow. (function- readBlob()) (currently in use for translog download in s3 plugin)

Related Issues

Resolves #13093

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Performance v2.14.0 labels Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

❌ Gradle check result for fe8ba21: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Compatibility status:

Checks if related components are compatible with change e947a3c

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Apr 8, 2024

❌ Gradle check result for 4ac7006: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 force-pushed the implement-change-s3-plugin branch from 4ac7006 to ca99c35 Compare April 8, 2024 09:23
Copy link
Contributor

github-actions bot commented Apr 8, 2024

❕ Gradle check result for ca99c35: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.51%. Comparing base (b15cb0c) to head (e947a3c).
Report is 153 commits behind head on main.

Files Patch % Lines
...rg/opensearch/repositories/s3/S3BlobContainer.java 85.71% 2 Missing ⚠️
...g/opensearch/common/blobstore/FetchBlobResult.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13113      +/-   ##
============================================
+ Coverage     71.42%   71.51%   +0.09%     
- Complexity    59978    60529     +551     
============================================
  Files          4985     5027      +42     
  Lines        282275   284598    +2323     
  Branches      40946    41219     +273     
============================================
+ Hits         201603   203538    +1935     
- Misses        63999    64253     +254     
- Partials      16673    16807     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skumawat2025 skumawat2025 requested a review from ashking94 April 8, 2024 10:24
@ashking94
Copy link
Member

ashking94 commented Apr 9, 2024

@skumawat2025 nit - Instead of non-async, you can mention it as sync.

non-async upload flow. (function - writeBlobAtomic()) (currently in use for other plugins)

Which plugin is it?

Signed-off-by: Sandeep Kumawat <[email protected]>
Copy link
Contributor

github-actions bot commented Apr 9, 2024

✅ Gradle check result for b528cfa: SUCCESS

Copy link
Contributor

❕ Gradle check result for f6d01db: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@skumawat2025
Copy link
Contributor Author

❕ Gradle check result for f6d01db: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky Test: #10558

Copy link
Contributor

❕ Gradle check result for 38903af: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@skumawat2025 skumawat2025 force-pushed the implement-change-s3-plugin branch from 38903af to 8247c56 Compare April 11, 2024 13:23
Copy link
Contributor

❌ Gradle check result for 8247c56: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sandeep Kumawat <[email protected]>
@skumawat2025 skumawat2025 force-pushed the implement-change-s3-plugin branch from 8247c56 to 44be3f2 Compare April 11, 2024 13:59
Copy link
Contributor

✅ Gradle check result for 44be3f2: SUCCESS

Signed-off-by: Sandeep Kumawat <[email protected]>
Copy link
Contributor

❕ Gradle check result for e947a3c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotWithLargeSegmentFiles

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sachinpkale sachinpkale merged commit 7345371 into opensearch-project:main Apr 12, 2024
31 of 33 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label May 20, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13113-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73453718a1c85565a3f7e4309d6fa83bf9a30522
# Push it to GitHub
git push --set-upstream origin backport/backport-13113-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13113-to-2.x.

skumawat2025 added a commit to skumawat2025/OpenSearch that referenced this pull request May 21, 2024
opensearch-project#13113)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025 added a commit to skumawat2025/OpenSearch that referenced this pull request May 21, 2024
opensearch-project#13113)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025 added a commit to skumawat2025/OpenSearch that referenced this pull request May 21, 2024
opensearch-project#13113)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025 added a commit to skumawat2025/OpenSearch that referenced this pull request May 21, 2024
opensearch-project#13113)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025 added a commit to skumawat2025/OpenSearch that referenced this pull request May 21, 2024
opensearch-project#13113)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025 added a commit to skumawat2025/OpenSearch that referenced this pull request May 21, 2024
opensearch-project#13113)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025 added a commit to skumawat2025/OpenSearch that referenced this pull request May 21, 2024
opensearch-project#13113)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025 added a commit to skumawat2025/OpenSearch that referenced this pull request May 22, 2024
opensearch-project#13113)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
sachinpkale pushed a commit that referenced this pull request May 22, 2024
#13113) (#13765)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <[email protected]>
@skumawat2025 skumawat2025 added v2.15.0 Issues and PRs related to version 2.15.0 and removed v2.14.0 labels Jun 11, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
opensearch-project#13113) (opensearch-project#13765)

* Implement interface changes for s3 plugin to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: kkewwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request skip-changelog Storage:Performance v2.15.0 Issues and PRs related to version 2.15.0
Projects
Status: ✅ Done
Status: Planned work items
Development

Successfully merging this pull request may close these issues.

[Remote Store] Implement introduced interface changes for s3 plugin
6 participants