Fix build due to multiple commits to same file causing compilation fa…

[gbbafna]

…ilure

Description

#12994 and #12821 were merged back to back w/o any merge conflicts . However build failed as the first PR did a refactor of a function used in second PR .

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[shourya035]

LGTM. This needs to be merged asap so that other builds are unblocked

[github-actions]

❌ Gradle check result for 60e483a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

Compatibility status:

Checks if related components are compatible with change bcbb01b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

[github-actions]

✅ Gradle check result for bcbb01b: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 71.45%. Comparing base (b15cb0c) to head (bcbb01b).
Report is 116 commits behind head on main.

Files	Patch %	Lines
...in/java/org/opensearch/index/shard/IndexShard.java	0.00%	1 Missing and 1 partial ⚠️
...org/opensearch/index/seqno/ReplicationTracker.java	50.00%	0 Missing and 1 partial ⚠️
...nsearch/index/shard/CheckpointRefreshListener.java	0.00%	0 Missing and 1 partial ⚠️
...s/replication/SegmentReplicationSourceFactory.java	0.00%	0 Missing and 1 partial ⚠️
...eplication/checkpoint/PublishCheckpointAction.java	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13019      +/-   ##
============================================
+ Coverage     71.42%   71.45%   +0.03%     
- Complexity    59978    60422     +444     
============================================
  Files          4985     5024      +39     
  Lines        282275   284294    +2019     
  Branches      40946    41173     +227     
============================================
+ Hits         201603   203138    +1535     
- Misses        63999    64334     +335     
- Partials      16673    16822     +149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.