Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DerivedFields] PR2 - Implementation for all supported types and DerivedFieldType #12808

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

rishabhmaurya
Copy link
Contributor

@rishabhmaurya rishabhmaurya commented Mar 21, 2024

Description

Derived Field PR2
Implementation for all supported types and DerivedFieldType. We support following types -

boolean
date
geo_point
ip
keyword
long
double

These changes are to be used in subsequent PR3(#12569) where DerivedFieldMapper is defined and used.

Related Issues

Resolves #12508

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
    - [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Mar 21, 2024

Compatibility status:

Checks if related components are compatible with change 1314baf

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for 6102b1e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rishabhmaurya rishabhmaurya changed the title DerivedField: PR-2 Implementation for all supported types and DerivedFieldType [DerivedField] PR2 - Implementation for all supported types and DerivedFieldType Mar 21, 2024
@rishabhmaurya rishabhmaurya marked this pull request as ready for review March 25, 2024 19:29
Copy link
Contributor

❌ Gradle check result for c1c687b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 1314baf: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@rishabhmaurya
Copy link
Contributor Author

rishabhmaurya commented Mar 26, 2024

For code coverage, we can rely on subsequent PR - https://github.com/opensearch-project/OpenSearch/pull/12569/checks?check_run_id=23082309493 and its coverage, which adds more tests. Its currently against main branch, so includes this PR change as well. This test will take care of a lot coverage missed in this one, since it relies on mapper functionality, thus its not included in this PR.

@msfroh msfroh added the backport 2.x Backport to 2.x branch label Mar 27, 2024
@msfroh msfroh merged commit 6ddbdcd into opensearch-project:main Mar 27, 2024
35 of 39 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 27, 2024
…vedFieldType (#12808)

Implementation for all supported types and DerivedFieldType.

We support the following types so far:

boolean
date
geo_point
ip
keyword
long
double

---------

Signed-off-by: Rishabh Maurya <[email protected]>
(cherry picked from commit 6ddbdcd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@msfroh msfroh added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Apr 2, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12808-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6ddbdcdc89507c95ca320b4112075cdf764e5d60
# Push it to GitHub
git push --set-upstream origin backport/backport-12808-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12808-to-2.x.

rishabhmaurya added a commit to rishabhmaurya/OpenSearch that referenced this pull request Apr 3, 2024
…vedFieldType (opensearch-project#12808)

Implementation for all supported types and DerivedFieldType.

We support the following types so far:

boolean
date
geo_point
ip
keyword
long
double

---------

Signed-off-by: Rishabh Maurya <[email protected]>
(cherry picked from commit 6ddbdcd)
@msfroh msfroh added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Apr 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 3, 2024
…vedFieldType (#12808)

Implementation for all supported types and DerivedFieldType.

We support the following types so far:

boolean
date
geo_point
ip
keyword
long
double

---------

Signed-off-by: Rishabh Maurya <[email protected]>
(cherry picked from commit 6ddbdcd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh pushed a commit that referenced this pull request Apr 3, 2024
…vedFieldType (#12808) (#13042)

Implementation for all supported types and DerivedFieldType.

We support the following types so far:

boolean
date
geo_point
ip
keyword
long
double

---------


(cherry picked from commit 6ddbdcd)

Signed-off-by: Rishabh Maurya <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@rishabhmaurya rishabhmaurya mentioned this pull request Apr 11, 2024
6 tasks
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…vedFieldType (opensearch-project#12808)

Implementation for all supported types and DerivedFieldType.

We support the following types so far:

boolean
date
geo_point
ip
keyword
long
double

---------

Signed-off-by: Rishabh Maurya <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Apr 29, 2024
…vedFieldType (opensearch-project#12808)

Implementation for all supported types and DerivedFieldType. 

We support the following types so far:

boolean
date
geo_point
ip
keyword
long
double

---------

Signed-off-by: Rishabh Maurya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Derived Fields] Add basic query support with derived fields
2 participants