-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test bwcSerialization issue in ForceMergeRequestTests #12778
Conversation
Signed-off-by: Gao Binlong <[email protected]>
@sohami, please help to review this PR, thank you! |
Compatibility status:Checks if related components are compatible with change e2d72d5 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for e2d72d5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Known issue:#5198 |
server/src/test/java/org/opensearch/action/admin/indices/forcemerge/ForceMergeRequestTests.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #12778 +/- ##
============================================
- Coverage 71.28% 71.17% -0.11%
- Complexity 60145 60259 +114
============================================
Files 4957 4972 +15
Lines 282799 283745 +946
Branches 41409 41498 +89
============================================
+ Hits 201591 201966 +375
- Misses 64189 64758 +569
- Partials 17019 17021 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit 90b2e4d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 90b2e4d) Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
As discussed in #12657, we should correct the version field in
ForceMergeRequests.testBwcSerialization()
, use the same version in both streamInput and streamOutput. The issue was fixed in that PR, but it cannot be backported to the 2.x branch because the serialization is different in main and 2.x, so we need to fix the issue in 2.x manually.Changelog is not needed.
Related Issues
#8021
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.