-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Add check for byte lag in time lag calculation #12565
Conversation
Compatibility status:Checks if related components are compatible with change b381ca0 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for 8db4b29: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2fdfb33: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ashish Singh <[email protected]>
❕ Gradle check result for b381ca0: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12565 +/- ##
============================================
+ Coverage 71.43% 71.48% +0.04%
- Complexity 59958 60036 +78
============================================
Files 4984 4984
Lines 282247 282247
Branches 40952 40952
============================================
+ Hits 201615 201752 +137
+ Misses 63903 63762 -141
- Partials 16729 16733 +4 ☔ View full report in Codecov by Sentry. |
server/src/test/java/org/opensearch/index/remote/RemoteSegmentTransferTrackerTests.java
Show resolved
Hide resolved
Signed-off-by: Ashish Singh <[email protected]> (cherry picked from commit 2b17902) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#12573) (cherry picked from commit 2b17902) Signed-off-by: Ashish Singh <[email protected]>
…arch-project#12565) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Aman Khare <[email protected]>
…arch-project#12565) Signed-off-by: Ashish Singh <[email protected]>
…arch-project#12565) Signed-off-by: Ashish Singh <[email protected]>
…arch-project#12565) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
In this PR, we are adding a defensive check which is used for determining the time lag. The time lag can show erroneous value if there is a refresh without any additional data ingested as segments.
Related Issues
No issue created.
Check List
[ ] New functionality includes testing.[ ] New functionality has been documented.[ ] New functionality has javadoc added[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.