-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase suite timeout for HighlighterSearchIT #12512
Conversation
@peternied @reta could you help review? Thanks! |
...rnalClusterTest/java/org/opensearch/search/fetch/subphase/highlight/HighlighterSearchIT.java
Show resolved
Hide resolved
Compatibility status:Checks if related components are compatible with change ab0a04c Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for 094331e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@jed326 my apologies , I am on vacation till the end of next week |
...rnalClusterTest/java/org/opensearch/search/fetch/subphase/highlight/HighlighterSearchIT.java
Show resolved
Hide resolved
Signed-off-by: Jay Deng <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12512 +/- ##
============================================
+ Coverage 71.37% 71.43% +0.05%
- Complexity 59891 59918 +27
============================================
Files 4972 4972
Lines 281783 281797 +14
Branches 40910 40913 +3
============================================
+ Hits 201136 201297 +161
+ Misses 63977 63791 -186
- Partials 16670 16709 +39 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jay Deng <[email protected]> (cherry picked from commit 9814eb9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 9814eb9) Signed-off-by: Jay Deng <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) Signed-off-by: Jay Deng <[email protected]>
) Signed-off-by: Jay Deng <[email protected]> Signed-off-by: Aman Khare <[email protected]>
) Signed-off-by: Jay Deng <[email protected]>
) Signed-off-by: Jay Deng <[email protected]>
) Signed-off-by: Jay Deng <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Increase suite timeout as parameterization has doubled the number of tests being run.
From the cases where the test does time out the non-concurrent search case is taking ~14 minutes, so bumping the timeout up to 35 to be safe.
Ref: #12119 (comment)
Related Issues
Resolves #12119
Check List
- [x] New functionality includes testing.- [x] New functionality has been documented.- [x] New functionality has javadoc added- [x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)!- [x] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.