Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Handle null partSize in OnDemandBlockSnapshotIndexInput (#9470) #12485

Merged

Conversation

andrross
Copy link
Member

@andrross andrross commented Feb 27, 2024

Backport c42ada8 from main to 2.x

This backport was missed from #9470

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…roject#9470)

The `partSize()` value can be null if the underlying repository
implementation does not implement file chunking.

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit c42ada8)
@andrross andrross changed the title Handle null partSize in OnDemandBlockSnapshotIndexInput (#9470) [Backport 2.x] Handle null partSize in OnDemandBlockSnapshotIndexInput (#9470) Feb 27, 2024
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 9c94e57

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❕ Gradle check result for 9c94e57: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.21%. Comparing base (bb2106f) to head (9c94e57).

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12485      +/-   ##
============================================
+ Coverage     71.08%   71.21%   +0.13%     
- Complexity    59945    60035      +90     
============================================
  Files          4945     4945              
  Lines        282334   282335       +1     
  Branches      41365    41366       +1     
============================================
+ Hits         200685   201065     +380     
+ Misses        64701    64316     -385     
- Partials      16948    16954       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal merged commit a1281f5 into opensearch-project:2.x Feb 27, 2024
85 checks passed
@andrross andrross deleted the backport/backport-9470-to-2.x branch February 28, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants