Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix a flaky test that relies on terminate_after for an exact count ma… #12343

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8fe15e6 from #12179.

#12179)

* Fix a flaky test that relies on terminate_after for an exact count match.  (Issue # 10435)

Signed-off-by: Austin Lee <[email protected]>

* Make comments HTML Javadoc friendly.

Signed-off-by: Austin Lee <[email protected]>

* Fix javadoc syntax

Signed-off-by: Andrew Ross <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit 8fe15e6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change b80cc6a

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for b80cc6a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Feb 16, 2024

❌ Gradle check result for b80cc6a: FAILURE

#9191
#12344

Copy link
Contributor

❕ Gradle check result for b80cc6a: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cafc515) 71.23% compared to head (b80cc6a) 71.22%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12343      +/-   ##
============================================
- Coverage     71.23%   71.22%   -0.02%     
- Complexity    59980    59984       +4     
============================================
  Files          4944     4944              
  Lines        282203   282203              
  Branches      41335    41335              
============================================
- Hits         201022   200993      -29     
+ Misses        64187    64170      -17     
- Partials      16994    17040      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit f0eb433 into 2.x Feb 16, 2024
56 of 82 checks passed
@github-actions github-actions bot deleted the backport/backport-12179-to-2.x branch February 16, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant