Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a system property to configure YamlParser codepoint limits #12301

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Feb 13, 2024

Description

Add a system property to configure YamlParser codepoint limits (similarly how we do it for other XContent parsers but this is YAML parser specific at the moment).

Related Issues

Closes #12276

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Compatibility status:

Checks if related components are compatible with change 5a55956

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for ad3d57e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5a55956: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented Feb 13, 2024

❌ Gradle check result for 5a55956: FAILURE

#12197
#9191

@reta
Copy link
Collaborator Author

reta commented Feb 13, 2024

Documentation update opensearch-project/documentation-website#6397

Copy link
Contributor

❕ Gradle check result for 5a55956: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76ae14a) 71.41% compared to head (5a55956) 71.40%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12301      +/-   ##
============================================
- Coverage     71.41%   71.40%   -0.01%     
- Complexity    59813    59849      +36     
============================================
  Files          4959     4959              
  Lines        281126   281129       +3     
  Branches      40857    40857              
============================================
- Hits         200753   200741      -12     
- Misses        63731    63736       +5     
- Partials      16642    16652      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit bff8eb7 into opensearch-project:main Feb 13, 2024
35 checks passed
@andrross andrross added the backport 2.x Backport to 2.x branch label Feb 13, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12301-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bff8eb7e3ef011a0575f064e51716d76f3447c80
# Push it to GitHub
git push --set-upstream origin backport/backport-12301-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12301-to-2.x.

reta added a commit to reta/OpenSearch that referenced this pull request Feb 13, 2024
reta added a commit to reta/OpenSearch that referenced this pull request Feb 14, 2024
andrross pushed a commit that referenced this pull request Feb 14, 2024
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed bug Something isn't working flaky-test Random test failure that succeeds on second run Other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.action.search.SearchResponseTests.testFromXContentWithFailures is flaky
3 participants