-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a system property to configure YamlParser codepoint limits #12301
Conversation
Compatibility status:Checks if related components are compatible with change 5a55956 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for ad3d57e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Andriy Redko <[email protected]>
❌ Gradle check result for 5a55956: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Documentation update opensearch-project/documentation-website#6397 |
libs/x-content/src/main/java/org/opensearch/common/xcontent/XContentContraints.java
Show resolved
Hide resolved
❕ Gradle check result for 5a55956: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12301 +/- ##
============================================
- Coverage 71.41% 71.40% -0.01%
- Complexity 59813 59849 +36
============================================
Files 4959 4959
Lines 281126 281129 +3
Branches 40857 40857
============================================
- Hits 200753 200741 -12
- Misses 63731 63736 +5
- Partials 16642 16652 +10 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12301-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bff8eb7e3ef011a0575f064e51716d76f3447c80
# Push it to GitHub
git push --set-upstream origin backport/backport-12301-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…earch-project#12301) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit bff8eb7)
…earch-project#12301) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit bff8eb7)
… (#12305) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit bff8eb7)
…earch-project#12301) Signed-off-by: Andriy Redko <[email protected]>
…earch-project#12301) Signed-off-by: Andriy Redko <[email protected]>
…earch-project#12301) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Add a system property to configure YamlParser codepoint limits (similarly how we do it for other XContent parsers but this is YAML parser specific at the moment).
Related Issues
Closes #12276
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.