Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: constant keyword field #12285

Merged
merged 32 commits into from
Apr 1, 2024

Conversation

hasnain2808
Copy link
Contributor

@hasnain2808 hasnain2808 commented Feb 11, 2024

Description

Adds a Constant Keyword Field

Related Issues

Resolves #9981

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR -> issue

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hasnain2808 hasnain2808 marked this pull request as draft February 11, 2024 06:32
@github-actions github-actions bot added discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request feature New feature or request good first issue Good for newcomers labels Feb 11, 2024
Signed-off-by: Mohammad Hasnain <[email protected]>
Signed-off-by: Mohammad Hasnain <[email protected]>
Signed-off-by: Mohammad Hasnain <[email protected]>
Signed-off-by: Mohammad Hasnain <[email protected]>
Signed-off-by: Mohammad Hasnain <[email protected]>
Signed-off-by: Mohammad Hasnain <[email protected]>
Signed-off-by: Mohammad Hasnain <[email protected]>
Signed-off-by: Mohammad Hasnain <[email protected]>
@msfroh msfroh force-pushed the feature-constant-keyword branch from 6cdd963 to 917b2bb Compare April 1, 2024 20:45
Copy link
Contributor

github-actions bot commented Apr 1, 2024

❌ Gradle check result for 917b2bb: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 1, 2024

✅ Gradle check result for 917b2bb: SUCCESS

@msfroh msfroh merged commit 1ec49bd into opensearch-project:main Apr 1, 2024
36 checks passed
@msfroh msfroh added the backport 2.x Backport to 2.x branch label Apr 1, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12285-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1ec49bd3aee6cd4463ae91ffb6c09054d1bbc02b
# Push it to GitHub
git push --set-upstream origin backport/backport-12285-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12285-to-2.x.

msfroh pushed a commit to msfroh/OpenSearch that referenced this pull request Apr 1, 2024
Constant keyword fields behave similarly to regular keyword fields, except that they are
defined only in the index mapping, and all documents in the index appear to have the same
value for the constant keyword field.

---------

Signed-off-by: Mohammad Hasnain <[email protected]>
(cherry picked from commit 1ec49bd)
dblock pushed a commit that referenced this pull request Apr 22, 2024
Constant keyword fields behave similarly to regular keyword fields, except that they are
defined only in the index mapping, and all documents in the index appear to have the same
value for the constant keyword field.

---------

Signed-off-by: Mohammad Hasnain <[email protected]>
(cherry picked from commit 1ec49bd)

Signed-off-by: Michael Froh <[email protected]>
Co-authored-by: Mohammad Hasnain Mohsin Rajan <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Constant keyword fields behave similarly to regular keyword fields, except that they are
defined only in the index mapping, and all documents in the index appear to have the same
value for the constant keyword field.

---------

Signed-off-by: Mohammad Hasnain <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Apr 29, 2024
Constant keyword fields behave similarly to regular keyword fields, except that they are 
defined only in the index mapping, and all documents in the index appear to have the same 
value for the constant keyword field.

---------

Signed-off-by: Mohammad Hasnain <[email protected]>
@dblock
Copy link
Member

dblock commented Jul 18, 2024

If I read #14807 this feature was broken when introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request feature New feature or request good first issue Good for newcomers Search Search query, autocomplete ...etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does Opensearch need constant_keyword field type?
4 participants