Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/backport 12005 to 2.x #12221

Conversation

atharvasharma61
Copy link
Contributor

@atharvasharma61 atharvasharma61 commented Feb 7, 2024


Signed-off-by: Atharva Sharma [email protected]
Signed-off-by: Atharva Sharma [email protected]
Co-authored-by: Atharva Sharma [email protected]
(cherry picked from commit c0fca74)

Description

Backport PR #12005

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…search-project#12005)

* bug fix to have RestActions rawPath as operation names, query params as tags and avoid using exact URI (opensearch-project#10791)

Signed-off-by: Atharva Sharma <[email protected]>

* Added UTs

Signed-off-by: Atharva Sharma <[email protected]>

* Added parameterized tests

Signed-off-by: Atharva Sharma <[email protected]>

* improvised parameterized tests using annotations

Signed-off-by: Atharva Sharma <[email protected]>

* removed unused annotations

Signed-off-by: Atharva Sharma <[email protected]>

* Added details in CHANGELOG.md

Signed-off-by: Atharva Sharma <[email protected]>

* Addressed spotlessJavaCheck failures

Signed-off-by: Atharva Sharma <[email protected]>

---------

Signed-off-by: Atharva Sharma <[email protected]>
Signed-off-by: Atharva Sharma <[email protected]>
Co-authored-by: Atharva Sharma <[email protected]>
(cherry picked from commit c0fca74)
@atharvasharma61 atharvasharma61 changed the title [BugFix] Fixing Span operation names generated from RestActions (#12005) Backport/backport 12005 to 2.x Feb 7, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Compatibility status:

Checks if related components are compatible with change 89f0dc1

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

github-actions bot commented Feb 7, 2024

✅ Gradle check result for 89f0dc1: SUCCESS

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (34dafac) 71.21% compared to head (89f0dc1) 71.03%.

Files Patch % Lines
.../org/opensearch/telemetry/tracing/SpanBuilder.java 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12221      +/-   ##
============================================
- Coverage     71.21%   71.03%   -0.19%     
+ Complexity    59918    59746     -172     
============================================
  Files          4939     4939              
  Lines        281646   281663      +17     
  Branches      41234    41237       +3     
============================================
- Hits         200588   200086     -502     
- Misses        64119    64592     +473     
- Partials      16939    16985      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gaganjuneja
Copy link
Contributor

@atharvasharma61, is it just a cherrypick only from the main branch right?

@atharvasharma61
Copy link
Contributor Author

Yes @Gaganjuneja

@sachinpkale sachinpkale merged commit 7fef055 into opensearch-project:2.x Feb 7, 2024
99 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants