Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Top N Queries by latency implementation #12203

Merged

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Feb 6, 2024

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Top N Queries by latency implementation
* Increase JavaDoc coverage and update PR based comments
* Refactor record and service to make them generic
* refactor service for improving multithreading efficiency
* rebase from master to pick up query insights plugin changes

---------

Signed-off-by: Chenyang Ji <[email protected]>
(cherry picked from commit 554cbf7)
@kotwanikunal
Copy link
Member

@ansjcy 2.12 branch is already cut. Please use backport 2.12 to add this change in.

@msfroh msfroh added the backport 2.12 Backport to 2.12 branch label Feb 6, 2024
@ansjcy ansjcy force-pushed the backport/backport-11904-to-2.x branch from 27e8f04 to ad6d179 Compare February 6, 2024 23:44
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Compatibility status:

Checks if related components are compatible with change ad6d179

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

github-actions bot commented Feb 7, 2024

❕ Gradle check result for 27e8f04: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (9f1f724) 71.04% compared to head (ad6d179) 71.13%.
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...ansport/top_queries/TransportTopQueriesAction.java 24.00% 18 Missing and 1 partial ⚠️
.../insights/core/listener/QueryInsightsListener.java 73.58% 10 Missing and 4 partials ⚠️
.../resthandler/top_queries/RestTopQueriesAction.java 61.11% 7 Missing ⚠️
.../insights/rules/action/top_queries/TopQueries.java 66.66% 5 Missing ⚠️
...s/rules/action/top_queries/TopQueriesResponse.java 93.18% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12203      +/-   ##
============================================
+ Coverage     71.04%   71.13%   +0.09%     
- Complexity    59740    59771      +31     
============================================
  Files          4929     4936       +7     
  Lines        281349   281517     +168     
  Branches      41202    41211       +9     
============================================
+ Hits         199890   200271     +381     
+ Misses        64543    64254     -289     
- Partials      16916    16992      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

❕ Gradle check result for ad6d179: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@msfroh msfroh merged commit 84db713 into opensearch-project:2.x Feb 7, 2024
29 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 7, 2024
(cherry picked from commit 84db713)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.12 Backport to 2.12 branch v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants