Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support dynamically adding SearchRequestOperationsListener (#11526) #12192

Merged

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Feb 6, 2024

Backport #11526 to 2.x


Signed-off-by: Chenyang Ji [email protected]
(cherry picked from commit 6aab360)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…h-project#11526)

Along the way, also refactored TransportSearchAction.TimeProvider,
so that it's no longer a (redundant) listener.

---------

Signed-off-by: Chenyang Ji <[email protected]>
(cherry picked from commit 6aab360)
Copy link
Contributor

github-actions bot commented Feb 6, 2024

❌ Gradle check result for 564fb69: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Chenyang Ji <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Compatibility status:

Checks if related components are compatible with change 60c0624

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git]

@ansjcy ansjcy changed the title Support dynamically adding SearchRequestOperationsListener (#11526) [Backport] Support dynamically adding SearchRequestOperationsListener (#11526) Feb 6, 2024
@ansjcy ansjcy changed the title [Backport] Support dynamically adding SearchRequestOperationsListener (#11526) [Backport 2.x] Support dynamically adding SearchRequestOperationsListener (#11526) Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

❕ Gradle check result for 60c0624: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (49c0c50) 71.15% compared to head (60c0624) 71.07%.

Files Patch % Lines
...action/search/SearchRequestOperationsListener.java 72.72% 3 Missing ⚠️
...opensearch/action/search/SearchRequestContext.java 60.00% 1 Missing and 1 partial ⚠️
...archRequestOperationsCompositeListenerFactory.java 85.71% 1 Missing and 1 partial ⚠️
...pensearch/action/search/TransportSearchAction.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12192      +/-   ##
============================================
- Coverage     71.15%   71.07%   -0.08%     
+ Complexity    59675    59667       -8     
============================================
  Files          4921     4922       +1     
  Lines        281132   281137       +5     
  Branches      41184    41177       -7     
============================================
- Hits         200050   199832     -218     
- Misses        64143    64381     +238     
+ Partials      16939    16924      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh merged commit 40ad938 into opensearch-project:2.x Feb 6, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants