Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Modify shrink exception to be more informative #12117

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Poojita-Raj
Copy link
Contributor

Description

For a call to shrink index in a segment replication enabled cluster, we perform a fast fail whenever the replica shards of the source index are not up to date with their primary shard. However, the exception we provide only asks customers/users to retry after sometime but does not specify how to check if their replicas are now up to date and ready for a retry of a shrink operation. Changed the exception to reflect this additional information.

Related Issues

Resolves #11352 partially.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added API Issues with external APIs enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep labels Jan 31, 2024
Copy link
Contributor

github-actions bot commented Jan 31, 2024

Compatibility status:

Checks if related components are compatible with change e0dc610

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

github-actions bot commented Feb 1, 2024

❌ Gradle check result for fb324cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 1, 2024

✅ Gradle check result for e0dc610: SUCCESS

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c07461) 71.40% compared to head (e0dc610) 71.32%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12117      +/-   ##
============================================
- Coverage     71.40%   71.32%   -0.08%     
+ Complexity    59505    59445      -60     
============================================
  Files          4925     4925              
  Lines        279540   279540              
  Branches      40646    40646              
============================================
- Hits         199594   199382     -212     
- Misses        63314    63535     +221     
+ Partials      16632    16623       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross added the backport 2.x Backport to 2.x branch label Feb 1, 2024
@andrross andrross merged commit f715ee1 into opensearch-project:main Feb 1, 2024
34 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 1, 2024
Signed-off-by: Poojita Raj <[email protected]>
(cherry picked from commit f715ee1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Feb 8, 2024
Signed-off-by: Poojita Raj <[email protected]>
(cherry picked from commit f715ee1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Feb 8, 2024
(cherry picked from commit f715ee1)

Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues with external APIs backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Segment Replication] Change validation for SegRep during Shrink operation to be async
3 participants