Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Support for Google Application Default Credentials (#8394) #12104

Conversation

yallen-ic
Copy link

backport #8394 to 1.x

Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…t#8394)

* fixed conflicts

Signed-off-by: fahadshamiinsta <[email protected]>

* applying spotless Java check

Signed-off-by: fahadshamiinsta <[email protected]>

* added a comment to test helper  method

Signed-off-by: fahadshamiinsta <[email protected]>

* added a comment to GoogleApplicationDefaultCredentials class with document reference

Signed-off-by: fahadshamiinsta <[email protected]>

* to rerun gradle checks

Signed-off-by: fahadshamiinsta <[email protected]>

* increasing coverage by adding another test

Signed-off-by: fahadshamiinsta <[email protected]>

* test name change

Signed-off-by: fahadshamiinsta <[email protected]>

* rerun ci

Signed-off-by: fahadshamiinsta <[email protected]>

* rerun ci

Signed-off-by: fahadshamiinsta <[email protected]>

* force push to rerun ci

Signed-off-by: fahadshamiinsta <[email protected]>

* pushing to trigger ci checks

Signed-off-by: fahadshamiinsta <[email protected]>

---------

Signed-off-by: fahadshamiinsta <[email protected]>
(cherry picked from commit 4c283a7)
@yallen-ic yallen-ic force-pushed the backport/backport-8394-to-1.x branch from 50e2e8d to 324e57f Compare February 5, 2024 02:42
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Gradle Check (Jenkins) Run Completed with:

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8560f93) 77.65% compared to head (fdfe1b9) 77.61%.
Report is 2 commits behind head on 1.x.

Files Patch % Lines
...ories/gcs/GoogleApplicationDefaultCredentials.java 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                1.x   #12104      +/-   ##
============================================
- Coverage     77.65%   77.61%   -0.04%     
  Complexity    58796    58796              
============================================
  Files          4223     4224       +1     
  Lines        253560   253577      +17     
  Branches      38701    38702       +1     
============================================
- Hits         196897   196819      -78     
- Misses        40666    40760      +94     
- Partials      15997    15998       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yallen-ic
Copy link
Author

Hi @deshsidd, I have fixed up the failing Gradle checks. Could you please have a re-review when you get a chance? We will really appreciate it.

Signed-off-by: fahadshamiinsta <[email protected]>
Signed-off-by: fahadshamiinsta <[email protected]>
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@yallen-ic
Copy link
Author

Hi @pajuric, changelog is added and the tests has all passed. We will really appreciate it if you could escalate this as per discussion with Arjun.

@dblock
Copy link
Member

dblock commented Feb 27, 2024

@reta @andrross have been ween backporting features into 1.x?

@andrross
Copy link
Member

@dblock Per the maintenance policy:

The software maintainers will not back-port fixes or features to versions outside of the maintenance window. That said, PRs with said back-ports are welcome and will follow the project’s review process. No new releases will result from these changes, but interested parties can create their own distribution from the updated source after the PRs are merged.

We won't backport a feature like this into a patch release (1.3.x) and have no plans to release a 1.4 version. However, if @yallen-ic and folks are interested in building their own distribution, then per my understanding of the policy we should accept this backport. @yallen-ic Are you intending to build your own 1.x distribution with this feature?

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrross, let's close this?

@yallen-ic
Copy link
Author

@andrross Thanks very much for the reply and info. Building our own distribution is out of scope of what we want to do, so we will be closing this PR.

@yallen-ic yallen-ic closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants