-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 1.x] Support for Google Application Default Credentials (#8394) #12104
[Backport 1.x] Support for Google Application Default Credentials (#8394) #12104
Conversation
Gradle Check (Jenkins) Run Completed with:
|
…t#8394) * fixed conflicts Signed-off-by: fahadshamiinsta <[email protected]> * applying spotless Java check Signed-off-by: fahadshamiinsta <[email protected]> * added a comment to test helper method Signed-off-by: fahadshamiinsta <[email protected]> * added a comment to GoogleApplicationDefaultCredentials class with document reference Signed-off-by: fahadshamiinsta <[email protected]> * to rerun gradle checks Signed-off-by: fahadshamiinsta <[email protected]> * increasing coverage by adding another test Signed-off-by: fahadshamiinsta <[email protected]> * test name change Signed-off-by: fahadshamiinsta <[email protected]> * rerun ci Signed-off-by: fahadshamiinsta <[email protected]> * rerun ci Signed-off-by: fahadshamiinsta <[email protected]> * force push to rerun ci Signed-off-by: fahadshamiinsta <[email protected]> * pushing to trigger ci checks Signed-off-by: fahadshamiinsta <[email protected]> --------- Signed-off-by: fahadshamiinsta <[email protected]> (cherry picked from commit 4c283a7)
50e2e8d
to
324e57f
Compare
Gradle Check (Jenkins) Run Completed with:
|
…udStorageClientSettings with 2.x arguments Signed-off-by: fahadshamiinsta <[email protected]>
Signed-off-by: fahadshamiinsta <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 1.x #12104 +/- ##
============================================
- Coverage 77.65% 77.61% -0.04%
Complexity 58796 58796
============================================
Files 4223 4224 +1
Lines 253560 253577 +17
Branches 38701 38702 +1
============================================
- Hits 196897 196819 -78
- Misses 40666 40760 +94
- Partials 15997 15998 +1 ☔ View full report in Codecov by Sentry. |
Hi @deshsidd, I have fixed up the failing Gradle checks. Could you please have a re-review when you get a chance? We will really appreciate it. |
Signed-off-by: fahadshamiinsta <[email protected]>
Signed-off-by: fahadshamiinsta <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Hi @pajuric, changelog is added and the tests has all passed. We will really appreciate it if you could escalate this as per discussion with Arjun. |
@dblock Per the maintenance policy:
We won't backport a feature like this into a patch release (1.3.x) and have no plans to release a 1.4 version. However, if @yallen-ic and folks are interested in building their own distribution, then per my understanding of the policy we should accept this backport. @yallen-ic Are you intending to build your own 1.x distribution with this feature? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andrross, let's close this?
@andrross Thanks very much for the reply and info. Building our own distribution is out of scope of what we want to do, so we will be closing this PR. |
backport #8394 to
1.x