-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test testThreeNodesNoClusterManagerBlock to retry list #12093
Conversation
Compatibility status:Checks if related components are compatible with change ceb5a2f Incompatible componentsIncompatible components: [https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git] |
❕ Gradle check result for e2cfa36: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12093 +/- ##
============================================
+ Coverage 71.31% 71.33% +0.02%
- Complexity 59423 59472 +49
============================================
Files 4925 4925
Lines 279513 279520 +7
Branches 40643 40645 +2
============================================
+ Hits 199329 199391 +62
- Misses 63594 63602 +8
+ Partials 16590 16527 -63 ☔ View full report in Codecov by Sentry. |
server/src/internalClusterTest/java/org/opensearch/cluster/MinimumClusterManagerNodesIT.java
Outdated
Show resolved
Hide resolved
e2cfa36
to
869c572
Compare
❌ Gradle check result for 869c572: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@kotwanikunal What do you think about muting versus adding it to the retry list? Neither option is good, but for a flaky test like this that is likely to pass on a retry it seems a little less severe than just muting it. |
Signed-off-by: Kunal Kotwani <[email protected]>
869c572
to
ceb5a2f
Compare
❕ Gradle check result for ceb5a2f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit 90a815e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 90a815e) Signed-off-by: Kunal Kotwani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ct#12093) Signed-off-by: Kunal Kotwani <[email protected]>
…ct#12093) Signed-off-by: Kunal Kotwani <[email protected]>
…ct#12093) Signed-off-by: Kunal Kotwani <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
testThreeNodesNoClusterManagerBlock
to the retry test listRelated Issues
Related: #10006
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.