-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flaky CloseIndexIT.testCloseWhileDeletingIndices #12049
Fix Flaky CloseIndexIT.testCloseWhileDeletingIndices #12049
Conversation
Compatibility status:Checks if related components are compatible with change d41c3d6 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security.git] |
❌ Gradle check result for 85c7dfb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sarthak Aggarwal <[email protected]>
85c7dfb
to
d41c3d6
Compare
❕ Gradle check result for d41c3d6: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12049 +/- ##
============================================
- Coverage 71.40% 71.37% -0.04%
+ Complexity 59465 59434 -31
============================================
Files 4925 4925
Lines 279471 279471
Branches 40635 40635
============================================
- Hits 199558 199472 -86
- Misses 63298 63396 +98
+ Partials 16615 16603 -12 ☔ View full report in Codecov by Sentry. |
@sarthakaggarwal97 Could you reliably reproduce this error within 5000 iterations in your local testing before increasing the timeout? |
@andrross, yes able to reproduce it currently in the 5000 iterations without the fix. Attaching screenshot for reference. |
Signed-off-by: Sarthak Aggarwal <[email protected]> (cherry picked from commit cfcb128) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit cfcb128) Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
The test was errorring out due to timeout.
Increased the timeout to 60s. 5000 iterations passed locally.
Screenshot of 1000 iterations passing:
Related Issues
Resolves #11610
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.