Fix missing shardFailure when filesystem throw exception

[jrj0823]

Fix missing shardFailure when Filesystem throw exception

Signed-off-by: jinrenjie.0823 [email protected]

Description

Fix the bug that shardFailure won't be triggered, when markStoreCorrupted() throws DirectoryIteratorException.

Related Issues

Resolves #12006

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change bbb9425

Incompatible components

Incompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git]

[github-actions]

❕ Gradle check result for fbc30ff: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationAllocationIT.testSingleIndexShardAllocation
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.45%. Comparing base (30aa8be) to head (fbc30ff).
Report is 574 commits behind head on main.

❗ Current head fbc30ff differs from pull request most recent head bbb9425

Please upload reports for the commit bbb9425 to get more accurate results.

Files	Patch %	Lines
.../main/java/org/opensearch/index/engine/Engine.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12007      +/-   ##
============================================
+ Coverage     71.33%   71.45%   +0.11%     
- Complexity    59438    59465      +27     
============================================
  Files          4923     4923              
  Lines        279218   279218              
  Branches      40596    40596              
============================================
+ Hits         199186   199506     +320     
+ Misses        63506    63142     -364     
- Partials      16526    16570      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[deshsidd]

Can we add tests for this ?

[deshsidd]

Commit not signed properly

[github-actions]

❌ Gradle check result for 981f1ec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for bbb9425: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[jrj0823]

Can we add tests for this ?

@deshsidd I have already added one test case and sign the commit properly

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[gaobinlong]

This change needs to be added to the changelog, please add it, resolve the conflicts with the latest main branch and then make sure all gradle checks pass, thanks!

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.