Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix: remove unnecessary trailing/missing leading slash from REST paths. #11995

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4167ac5 from #11992.

Signed-off-by: dblock <[email protected]>
(cherry picked from commit 4167ac5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 2c5b83d

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git]

Copy link
Contributor

❌ Gradle check result for 2c5b83d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Jan 23, 2024

❌ Gradle check result for 2c5b83d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock #10006
org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing #9191
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit #8946
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits #8638
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit #8947
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh #8638

Copy link
Contributor

❌ Gradle check result for 2c5b83d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Jan 23, 2024

❌ Gradle check result for 2c5b83d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.client.TasksIT.testGetValidTask looks transient
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit #8946
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits #8638
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit #8947
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh #8638

Copy link
Contributor

❕ Gradle check result for 2c5b83d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c40fcff) 71.12% compared to head (2c5b83d) 71.26%.
Report is 2 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11995      +/-   ##
============================================
+ Coverage     71.12%   71.26%   +0.14%     
- Complexity    59361    59478     +117     
============================================
  Files          4891     4891              
  Lines        279940   279940              
  Branches      41055    41055              
============================================
+ Hits         199099   199498     +399     
+ Misses        63957    63587     -370     
+ Partials      16884    16855      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal merged commit b72f1d1 into 2.x Jan 23, 2024
56 of 82 checks passed
@github-actions github-actions bot deleted the backport/backport-11992-to-2.x branch January 23, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants