[Bugfix] Pass TwoPhaseIterator from subQueryScorer

[noCharger]

Description

This is a bug when _score is included in script, and the TwoPhaseIterator of a MinScoreScorer doesn't check the ScriptScorer for a match before asking it for a score for the current doc:

OpenSearch/server/src/main/java/org/opensearch/common/lucene/search/function/MinScoreScorer.java

Lines 98 to 103 in a9ce180

	// we need to check the two-phase iterator first
	// otherwise calling score() is illegal
	if (inTwoPhase != null && inTwoPhase.matches() == false) {
	return false;
	}
	curScore = in.score();

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

#8155

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change 57a2d5b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

[deshsidd]

Please sign your commits and fix the builds.

[deshsidd]

Can we also add some tests to verify this behavior before and after. thanks

[noCharger]

Please sign your commits and fix the builds.

Hi @deshsidd, this PR is still in progress. Please take look when it's ready for review.

[github-actions]

✅ Gradle check result for b878dcf: SUCCESS

[codecov]

Codecov Report

Attention: 138 lines in your changes are missing coverage. Please review.

Comparison is base (3cbf54e) 71.40% compared to head (57a2d5b) 71.37%.
Report is 8 commits behind head on main.

Files	Patch %	Lines
...rch/search/fetch/subphase/MatchedQueriesPhase.java	0.00%	37 Missing ⚠️
...src/main/java/org/opensearch/search/SearchHit.java	58.73%	17 Missing and 9 partials ⚠️
...ansport/top_queries/TransportTopQueriesAction.java	24.00%	18 Missing and 1 partial ⚠️
.../insights/core/listener/QueryInsightsListener.java	73.58%	10 Missing and 4 partials ⚠️
...opensearch/search/builder/SearchSourceBuilder.java	42.85%	4 Missing and 4 partials ⚠️
.../resthandler/top_queries/RestTopQueriesAction.java	61.11%	7 Missing ⚠️
.../insights/rules/action/top_queries/TopQueries.java	66.66%	5 Missing ⚠️
...search/ingest/common/RemoveByPatternProcessor.java	95.77%	1 Missing and 2 partials ⚠️
...s/rules/action/top_queries/TopQueriesResponse.java	93.18%	3 Missing ⚠️
...g/opensearch/search/internal/SubSearchContext.java	0.00%	3 Missing ⚠️
... and 8 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11954      +/-   ##
============================================
- Coverage     71.40%   71.37%   -0.04%     
- Complexity    59636    59687      +51     
============================================
  Files          4944     4952       +8     
  Lines        280322   280638     +316     
  Branches      40728    40773      +45     
============================================
+ Hits         200175   200313     +138     
- Misses        63501    63678     +177     
- Partials      16646    16647       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

❌ Gradle check result for e364dc6:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for cdc3cae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[noCharger]

❌ Gradle check result for cdc3cae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

All failes are flaky test cases https://build.ci.opensearch.org/job/gradle-check/33431/testReport/

Ref #7755

[github-actions]

✅ Gradle check result for 57a2d5b: SUCCESS