-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Apply the fast filter optimization to composite aggregation #11914
Conversation
We can do efficient DateHistogram aggregation under composite aggregations. --------- Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit d5a6f99) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Compatibility status:Checks if related components are compatible with change 185ca45 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git] |
❌ Gradle check result for 185ca45: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 185ca45: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 185ca45: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #11914 +/- ##
============================================
- Coverage 71.04% 71.03% -0.02%
+ Complexity 59352 59332 -20
============================================
Files 4890 4891 +1
Lines 279826 279957 +131
Branches 41035 41064 +29
============================================
+ Hits 198799 198854 +55
- Misses 64210 64219 +9
- Partials 16817 16884 +67 ☔ View full report in Codecov by Sentry. |
…11914) We can do efficient DateHistogram aggregation under composite aggregations. --------- (cherry picked from commit d5a6f99) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 6ed7565) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/backport-2.12
# Create a new branch
git switch --create backport/backport-11914-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6ed7565e6e63c7f80c1954b6bbcc16d44534a9d7
# Push it to GitHub
git push --set-upstream origin backport/backport-11914-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.12 Then, create a pull request where the |
…11914) We can do efficient DateHistogram aggregation under composite aggregations. --------- (cherry picked from commit d5a6f99) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 6ed7565) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Backport d5a6f99 from #11505.