Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Apply the fast filter optimization to composite aggregation #11914

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d5a6f99 from #11505.

We can do efficient DateHistogram aggregation under composite
aggregations.

---------

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit d5a6f99)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 185ca45

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git]

Copy link
Contributor

❌ Gradle check result for 185ca45: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 185ca45: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 185ca45: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadRangeBlobWithRetries
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (c48fb55) 71.04% compared to head (185ca45) 71.03%.
Report is 27 commits behind head on 2.x.

Files Patch % Lines
...h/aggregations/bucket/FastFilterRewriteHelper.java 88.88% 3 Missing and 12 partials ⚠️
...egations/bucket/composite/CompositeAggregator.java 88.37% 3 Missing and 2 partials ⚠️
...va/org/opensearch/ingest/common/CopyProcessor.java 93.61% 3 Missing ⚠️
...gregations/bucket/composite/InternalComposite.java 0.00% 2 Missing ⚠️
...ions/bucket/histogram/DateHistogramAggregator.java 84.61% 0 Missing and 2 partials ⚠️
...g/opensearch/ingest/common/IngestCommonPlugin.java 0.00% 1 Missing ⚠️
.../bucket/histogram/AutoDateHistogramAggregator.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11914      +/-   ##
============================================
- Coverage     71.04%   71.03%   -0.02%     
+ Complexity    59352    59332      -20     
============================================
  Files          4890     4891       +1     
  Lines        279826   279957     +131     
  Branches      41035    41064      +29     
============================================
+ Hits         198799   198854      +55     
- Misses        64210    64219       +9     
- Partials      16817    16884      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh merged commit 6ed7565 into 2.x Feb 7, 2024
79 checks passed
@github-actions github-actions bot deleted the backport/backport-11505-to-2.x branch February 7, 2024 18:46
@bowenlan-amzn bowenlan-amzn added the backport 2.12 Backport to 2.12 branch label Feb 7, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 7, 2024
…11914)

We can do efficient DateHistogram aggregation under composite
aggregations.

---------

(cherry picked from commit d5a6f99)

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 6ed7565)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@msfroh msfroh added backport 2.12 Backport to 2.12 branch and removed backport 2.12 Backport to 2.12 branch labels Feb 10, 2024
@opensearch-trigger-bot
Copy link
Contributor Author

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/backport-2.12
# Create a new branch
git switch --create backport/backport-11914-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6ed7565e6e63c7f80c1954b6bbcc16d44534a9d7
# Push it to GitHub
git push --set-upstream origin backport/backport-11914-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport/backport-11914-to-2.12.

@msfroh msfroh added backport 2.12 Backport to 2.12 branch and removed backport 2.12 Backport to 2.12 branch labels Feb 10, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 10, 2024
…11914)

We can do efficient DateHistogram aggregation under composite
aggregations.

---------

(cherry picked from commit d5a6f99)

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 6ed7565)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.12 Backport to 2.12 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants