Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Ensure Jackson default maximums introduced in 2.16.0 do not conflict with OpenSearch settings (#11811) #11871

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Jan 12, 2024

Backport of #11811 to 2.x

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Compatibility status:

Checks if related components are compatible with change 90c74ae

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git]

Copy link
Contributor

❌ Gradle check result for 7886d1a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the backport/backport-11811-to-2.x branch from 7886d1a to 94ef12d Compare January 12, 2024 14:33
Copy link
Contributor

❌ Gradle check result for 94ef12d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the backport/backport-11811-to-2.x branch from 94ef12d to 26ba6ac Compare January 12, 2024 15:08
Copy link
Contributor

❌ Gradle check result for 26ba6ac: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the backport/backport-11811-to-2.x branch from 26ba6ac to 8045c60 Compare January 12, 2024 15:35
Copy link
Contributor

❌ Gradle check result for 8045c60: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the backport/backport-11811-to-2.x branch from 8045c60 to 2d3b4f9 Compare January 12, 2024 16:23
@reta
Copy link
Collaborator Author

reta commented Jan 12, 2024

❌ Gradle check result for 8045c60: FAILURE

#8947

…with OpenSearch settings (opensearch-project#11811)

* Ensure Jackson default maximums introduced in 2.16.0 do not conflict with OpenSearch settings

Signed-off-by: Andriy Redko <[email protected]>

* Address code review comments

Signed-off-by: Andriy Redko <[email protected]>

* Address code review comments

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 5c82ab8)
Signed-off-by: Andriy Redko <[email protected]>
@reta reta force-pushed the backport/backport-11811-to-2.x branch from 2d3b4f9 to 90c74ae Compare January 12, 2024 17:11
Copy link
Contributor

❕ Gradle check result for 2d3b4f9: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.test.rest.ClientYamlTestSuiteIT.test {p0=search.aggregation/20_terms/string profiler via global ordinals}
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (677ea55) 71.07% compared to head (90c74ae) 71.13%.
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...ava/org/opensearch/index/mapper/MapperService.java 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11871      +/-   ##
============================================
+ Coverage     71.07%   71.13%   +0.06%     
+ Complexity    59329    59307      -22     
============================================
  Files          4889     4890       +1     
  Lines        279810   279838      +28     
  Branches      41035    41035              
============================================
+ Hits         198866   199063     +197     
+ Misses        64071    63837     -234     
- Partials      16873    16938      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 90c74ae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented Jan 12, 2024

❌ Gradle check result for 90c74ae: FAILURE

#11091
#11256
#9773
#8947
#8945

Copy link
Contributor

❌ Gradle check result for 90c74ae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented Jan 12, 2024

❌ Gradle check result for 90c74ae: FAILURE

#11256
#9773
#8947
#8945
#10983
#11875

Copy link
Contributor

❕ Gradle check result for 90c74ae: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta reta merged commit 729b725 into opensearch-project:2.x Jan 12, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants