[Searchable Snapshot] Add Relevant Error handling for Index Creation with remote_snapshot. #11867

Rishikesh1159 · 2024-01-12T05:38:48Z

Description

This PR adds appropriate error handling in Index creation path when user attempts to set index.store.type to remote_snapshot while index creation. More info can be found [here ](https://github.com/opensearch-project/OpenSearch/pull/11840#discussion_r1449330279)

Related Issues

Resolves #11658, #11840

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…_snaphot Signed-off-by: Rishikesh1159 <[email protected]>

github-actions · 2024-01-12T05:54:11Z

❌ Gradle check result for 0933fe0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-01-12T06:00:03Z

Compatibility status:

Checks if related components are compatible with change 417fe3c

Incompatible components

Incompatible components: [https://github.com/opensearch-project/custom-codecs.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Signed-off-by: Rishikesh1159 <[email protected]>

github-actions · 2024-01-12T17:28:47Z

✅ Gradle check result for f08daa1: SUCCESS

codecov · 2024-01-12T17:30:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76f7e73) 71.36% compared to head (c7a9c38) 71.33%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11867      +/-   ##
============================================
- Coverage     71.36%   71.33%   -0.04%     
- Complexity    59354    59379      +25     
============================================
  Files          4923     4923              
  Lines        279223   279226       +3     
  Branches      40597    40598       +1     
============================================
- Hits         199271   199188      -83     
- Misses        63374    63437      +63     
- Partials      16578    16601      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rishikesh1159 <[email protected]>

github-actions · 2024-01-12T19:42:04Z

❌ Gradle check result for be471e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-01-17T22:26:47Z

❕ Gradle check result for be471e9: UNSTABLE

TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadBlobWithRetries
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessOnThirdAttempt

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java

server/src/internalClusterTest/java/org/opensearch/snapshots/SearchableSnapshotIT.java

Signed-off-by: Rishikesh1159 <[email protected]>

github-actions · 2024-01-20T01:56:21Z

✅ Gradle check result for f2391ab: SUCCESS

github-actions · 2024-01-20T02:01:03Z

✅ Gradle check result for e7863b9: SUCCESS

andrross

@Rishikesh1159 Let's a changelog entry under the "Fixed" section. Something like "Prevent setting remote_snapshot store type on index creation"

Signed-off-by: Rishikesh1159 <[email protected]>

Signed-off-by: Rishikesh Pasham <[email protected]>

github-actions · 2024-01-24T21:30:46Z

❌ Gradle check result for c7a9c38: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Rishikesh1159 · 2024-01-24T21:37:52Z

❌ Gradle check result for c7a9c38: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#11454

github-actions · 2024-01-24T21:43:01Z

❕ Gradle check result for 417fe3c: UNSTABLE

TEST FAILURES:

      2 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2024-01-24T22:35:42Z

❌ Gradle check result for c7a9c38: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Rishikesh1159 · 2024-01-25T01:14:22Z

❌ Gradle check result for c7a9c38: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#9191, #10006

github-actions · 2024-01-25T02:02:28Z

❕ Gradle check result for c7a9c38: UNSTABLE

TEST FAILURES:

      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

…with remote_snapshot. (#11867) * Block index creation when setting property index.store.type to remote_snaphot Signed-off-by: Rishikesh1159 <[email protected]> * Adding null check. Signed-off-by: Rishikesh1159 <[email protected]> * fix failing test Signed-off-by: Rishikesh1159 <[email protected]> * remove unnecessary test. Signed-off-by: Rishikesh1159 <[email protected]> * Address comments on PR. Signed-off-by: Rishikesh1159 <[email protected]> * Resolve conflicts on PR. Signed-off-by: Rishikesh1159 <[email protected]> * Add changelog entry. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh Pasham <[email protected]> (cherry picked from commit c1bd752) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…with remote_snapshot. (#11867) (#12021) * Block index creation when setting property index.store.type to remote_snaphot * Adding null check. * fix failing test * remove unnecessary test. * Address comments on PR. * Resolve conflicts on PR. * Add changelog entry. --------- (cherry picked from commit c1bd752) Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh Pasham <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…with remote_snapshot. (opensearch-project#11867) * Block index creation when setting property index.store.type to remote_snaphot Signed-off-by: Rishikesh1159 <[email protected]> * Adding null check. Signed-off-by: Rishikesh1159 <[email protected]> * fix failing test Signed-off-by: Rishikesh1159 <[email protected]> * remove unnecessary test. Signed-off-by: Rishikesh1159 <[email protected]> * Address comments on PR. Signed-off-by: Rishikesh1159 <[email protected]> * Resolve conflicts on PR. Signed-off-by: Rishikesh1159 <[email protected]> * Add changelog entry. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh Pasham <[email protected]>

…with remote_snapshot. (opensearch-project#11867) * Block index creation when setting property index.store.type to remote_snaphot Signed-off-by: Rishikesh1159 <[email protected]> * Adding null check. Signed-off-by: Rishikesh1159 <[email protected]> * fix failing test Signed-off-by: Rishikesh1159 <[email protected]> * remove unnecessary test. Signed-off-by: Rishikesh1159 <[email protected]> * Address comments on PR. Signed-off-by: Rishikesh1159 <[email protected]> * Resolve conflicts on PR. Signed-off-by: Rishikesh1159 <[email protected]> * Add changelog entry. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh Pasham <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>

Block index creation when setting property index.store.type to remote…

0933fe0

…_snaphot Signed-off-by: Rishikesh1159 <[email protected]>

github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Searchable Snapshots labels Jan 12, 2024

Adding null check.

13f2c08

Signed-off-by: Rishikesh1159 <[email protected]>

remove unnecessary test.

be471e9

Signed-off-by: Rishikesh1159 <[email protected]>

andrross reviewed Jan 18, 2024

View reviewed changes

Rishikesh1159 added 2 commits January 20, 2024 01:05

Address comments on PR.

f2391ab

Signed-off-by: Rishikesh1159 <[email protected]>

Resolve conflicts on PR.

e7863b9

Signed-off-by: Rishikesh1159 <[email protected]>

andrross reviewed Jan 23, 2024

View reviewed changes

Rishikesh1159 mentioned this pull request Jan 24, 2024

[Searchable Snapshot] Add Relevant Error handling for Restore API with remote_snapshot. #11840

Merged

8 tasks

Rishikesh1159 and others added 2 commits January 24, 2024 20:36

Add changelog entry.

417fe3c

Signed-off-by: Rishikesh1159 <[email protected]>

Merge branch 'main' into index_store_type_error_jandling

c7a9c38

Signed-off-by: Rishikesh Pasham <[email protected]>

kotwanikunal approved these changes Jan 24, 2024

View reviewed changes

Rishikesh1159 added the backport 2.x Backport to 2.x branch label Jan 25, 2024

Rishikesh1159 merged commit c1bd752 into opensearch-project:main Jan 25, 2024
51 of 57 checks passed

opensearch-trigger-bot bot mentioned this pull request Jan 25, 2024

[Backport 2.x] [Searchable Snapshot] Add Relevant Error handling for Index Creation with remote_snapshot. #12021

Merged

BrewTestBot mentioned this pull request Feb 21, 2024

opensearch 2.12.0 Homebrew/homebrew-core#163463

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Searchable Snapshot] Add Relevant Error handling for Index Creation with remote_snapshot. #11867

[Searchable Snapshot] Add Relevant Error handling for Index Creation with remote_snapshot. #11867

Rishikesh1159 commented Jan 12, 2024 •

edited

Loading

github-actions bot commented Jan 12, 2024

github-actions bot commented Jan 12, 2024 •

edited

Loading

github-actions bot commented Jan 12, 2024

codecov bot commented Jan 12, 2024 •

edited

Loading

github-actions bot commented Jan 12, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 20, 2024

github-actions bot commented Jan 20, 2024

andrross left a comment

github-actions bot commented Jan 24, 2024

Rishikesh1159 commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

Rishikesh1159 commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

[Searchable Snapshot] Add Relevant Error handling for Index Creation with remote_snapshot. #11867

[Searchable Snapshot] Add Relevant Error handling for Index Creation with remote_snapshot. #11867

Conversation

Rishikesh1159 commented Jan 12, 2024 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Jan 12, 2024

github-actions bot commented Jan 12, 2024 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Jan 12, 2024

codecov bot commented Jan 12, 2024 • edited Loading

Codecov Report

github-actions bot commented Jan 12, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 20, 2024

github-actions bot commented Jan 20, 2024

andrross left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 24, 2024

Rishikesh1159 commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

Rishikesh1159 commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

Rishikesh1159 commented Jan 12, 2024 •

edited

Loading

github-actions bot commented Jan 12, 2024 •

edited

Loading

codecov bot commented Jan 12, 2024 •

edited

Loading