-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new feature flag "WRITEABLE_REMOTE_INDEX" to gate the writeable remote index functionality #11717
Introduce a new feature flag "WRITEABLE_REMOTE_INDEX" to gate the writeable remote index functionality #11717
Conversation
…ionality. Signed-off-by: Rishikesh1159 <[email protected]>
Compatibility status:Checks if related components are compatible with change 5fa405b Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
❕ Gradle check result for 007a3cd: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11717 +/- ##
============================================
- Coverage 71.41% 71.32% -0.09%
+ Complexity 59232 59208 -24
============================================
Files 4909 4909
Lines 278427 278428 +1
Branches 40460 40460
============================================
- Hits 198826 198588 -238
- Misses 63141 63386 +245
+ Partials 16460 16454 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add in a CHANGELOG entry?
Signed-off-by: Rishikesh1159 <[email protected]>
❌ Gradle check result for 32c3d01: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 32c3d01: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Rishikesh1159 <[email protected]>
❌ Gradle check result for 5fa405b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
known flaky test: #10006 |
❕ Gradle check result for 5fa405b: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…teable remote index functionality (#11717) * Introduce a new feature flag to gate the writeable remote index functionality. Signed-off-by: Rishikesh1159 <[email protected]> * Add changelog entry. Signed-off-by: Rishikesh1159 <[email protected]> * Update changelog entry. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit ab0f70e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…teable remote index functionality (#11717) (#11772) * Introduce a new feature flag to gate the writeable remote index functionality. * Add changelog entry. * Update changelog entry. --------- (cherry picked from commit ab0f70e) Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…teable remote index functionality (opensearch-project#11717) * Introduce a new feature flag to gate the writeable remote index functionality. Signed-off-by: Rishikesh1159 <[email protected]> * Add changelog entry. Signed-off-by: Rishikesh1159 <[email protected]> * Update changelog entry. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]>
…teable remote index functionality (opensearch-project#11717) * Introduce a new feature flag to gate the writeable remote index functionality. Signed-off-by: Rishikesh1159 <[email protected]> * Add changelog entry. Signed-off-by: Rishikesh1159 <[email protected]> * Update changelog entry. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR introduces new
WRITEABLE_REMOTE_INDEX
feature flag to gate the writeable remote index functionality.Related Issues
Resolves #11705
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.