Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new feature flag "WRITEABLE_REMOTE_INDEX" to gate the writeable remote index functionality #11717

Conversation

Rishikesh1159
Copy link
Member

@Rishikesh1159 Rishikesh1159 commented Jan 3, 2024

Description

This PR introduces new WRITEABLE_REMOTE_INDEX feature flag to gate the writeable remote index functionality.

Related Issues

Resolves #11705

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Compatibility status:

Checks if related components are compatible with change 5fa405b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Jan 3, 2024

❕ Gradle check result for 007a3cd: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b1c2c7) 71.41% compared to head (5fa405b) 71.32%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11717      +/-   ##
============================================
- Coverage     71.41%   71.32%   -0.09%     
+ Complexity    59232    59208      -24     
============================================
  Files          4909     4909              
  Lines        278427   278428       +1     
  Branches      40460    40460              
============================================
- Hits         198826   198588     -238     
- Misses        63141    63386     +245     
+ Partials      16460    16454       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kotwanikunal kotwanikunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add in a CHANGELOG entry?

Signed-off-by: Rishikesh1159 <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Gradle check result for 32c3d01: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❕ Gradle check result for 32c3d01: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Rishikesh1159 <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Gradle check result for 5fa405b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Rishikesh1159
Copy link
Member Author

❌ Gradle check result for 5fa405b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

known flaky test: #10006

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❕ Gradle check result for 5fa405b: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@Rishikesh1159 Rishikesh1159 added the backport 2.x Backport to 2.x branch label Jan 5, 2024
@Rishikesh1159 Rishikesh1159 merged commit ab0f70e into opensearch-project:main Jan 5, 2024
33 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 5, 2024
…teable remote index functionality (#11717)

* Introduce a new feature flag to gate the writeable remote index functionality.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add changelog entry.

Signed-off-by: Rishikesh1159 <[email protected]>

* Update changelog entry.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
(cherry picked from commit ab0f70e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Rishikesh1159 pushed a commit that referenced this pull request Jan 5, 2024
…teable remote index functionality (#11717) (#11772)

* Introduce a new feature flag to gate the writeable remote index functionality.



* Add changelog entry.



* Update changelog entry.



---------


(cherry picked from commit ab0f70e)

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…teable remote index functionality (opensearch-project#11717)

* Introduce a new feature flag to gate the writeable remote index functionality.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add changelog entry.

Signed-off-by: Rishikesh1159 <[email protected]>

* Update changelog entry.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…teable remote index functionality (opensearch-project#11717)

* Introduce a new feature flag to gate the writeable remote index functionality.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add changelog entry.

Signed-off-by: Rishikesh1159 <[email protected]>

* Update changelog entry.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Search:Remote Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a new feature flag to gate the “writeable remote index” functionality
2 participants