Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Implementation for match_only_text field #11714

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7b1c2c7 from #11039.

* Implementation for match_only_text field

Signed-off-by: Rishabh Maurya <[email protected]>

* Fix build failures

Signed-off-by: Rishabh Maurya <[email protected]>

* Fix bugs

Signed-off-by: Rishabh Maurya <[email protected]>

* Added mapper tests, stil failing on prefix and phrase tests

Signed-off-by: Rishabh Maurya <[email protected]>

* Disable index prefix and phrase mapper

Signed-off-by: Rishabh Maurya <[email protected]>

* Added unit tests for phrase and multiphrase query validation

Signed-off-by: Rishabh Maurya <[email protected]>

* Add unit tests for prefix and prefix phrase queries

Signed-off-by: Rishabh Maurya <[email protected]>

* Add a test to cover 3 word with synonym match phrase prefix query

Signed-off-by: Rishabh Maurya <[email protected]>

* Add unit test for SourceFieldMatchQuery

Signed-off-by: Rishabh Maurya <[email protected]>

* Added test for _source disabled case

Signed-off-by: Rishabh Maurya <[email protected]>

* Add unit test for missing field

Signed-off-by: Rishabh Maurya <[email protected]>

* more validation tests and changelog update

Signed-off-by: Rishabh Maurya <[email protected]>

* Added integration tests for match_only_text replicating text field integ tests

Signed-off-by: Rishabh Maurya <[email protected]>

* Added skip section in integ test to fix mixed cluster failures

Signed-off-by: Rishabh Maurya <[email protected]>

* remove unused import

Signed-off-by: Rishabh Maurya <[email protected]>

* Address PR comments

Signed-off-by: Rishabh Maurya <[email protected]>

* fix integ tests

Signed-off-by: Rishabh Maurya <[email protected]>

* Fix flaky test due to random indexwriter

Signed-off-by: Rishabh Maurya <[email protected]>

* pr comment: header modification

Signed-off-by: Rishabh Maurya <[email protected]>

* Address PR comments

Signed-off-by: Rishabh Maurya <[email protected]>

* addded change to the right section of CHANGELOG

Signed-off-by: Rishabh Maurya <[email protected]>

* overriding the textFieldType before every test

Signed-off-by: Rishabh Maurya <[email protected]>

* rename @before method

Signed-off-by: Rishabh Maurya <[email protected]>

* update changelog description

Signed-off-by: Rishabh Maurya <[email protected]>

---------

Signed-off-by: Rishabh Maurya <[email protected]>
(cherry picked from commit 7b1c2c7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Compatibility status:

Checks if related components are compatible with change d381a59

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

github-actions bot commented Jan 3, 2024

✅ Gradle check result for d381a59: SUCCESS

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (ab9c3c6) 71.15% compared to head (d381a59) 71.20%.
Report is 2 commits behind head on 2.x.

Files Patch % Lines
.../opensearch/index/query/SourceFieldMatchQuery.java 67.34% 8 Missing and 8 partials ⚠️
...nsearch/index/mapper/MatchOnlyTextFieldMapper.java 93.54% 4 Missing and 4 partials ⚠️
...h/cluster/metadata/MetadataCreateIndexService.java 92.30% 0 Missing and 1 partial ⚠️
...a/org/opensearch/index/search/MultiMatchQuery.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11714      +/-   ##
============================================
+ Coverage     71.15%   71.20%   +0.05%     
- Complexity    59365    59407      +42     
============================================
  Files          4883     4885       +2     
  Lines        279314   279506     +192     
  Branches      40934    40967      +33     
============================================
+ Hits         198749   199030     +281     
+ Misses        63740    63652      -88     
+ Partials      16825    16824       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit d39c1d0 into 2.x Jan 3, 2024
81 checks passed
@github-actions github-actions bot deleted the backport/backport-11039-to-2.x branch January 3, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant