-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fast Local datetime parser for local date time #11675
base: main
Are you sure you want to change the base?
Added fast Local datetime parser for local date time #11675
Conversation
Signed-off-by: Prabhat Sharma <[email protected]>
❌ Gradle check result for f8dd4a2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 167c765 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/alerting.git] |
Signed-off-by: Prabhat Sharma <[email protected]>
f8dd4a2
to
167c765
Compare
❌ Gradle check result for 167c765: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This PR is stalled because it has been open for 30 days with no activity. |
@CaptainDredge Can you look into taking this PR to closure (I see tests failing)? I believe this should be a good enhancement to the new format parsing already added. Community can help review once the tests are passing |
This PR is stalled because it has been open for 30 days with no activity. |
@CaptainDredge Can we update the PR and close this one. |
@ankitkala I can help take this to closure. |
Description
This PR adds new
local_date_time
format for datetime parsing whose implementation is not based on the usual java datetime formatters but is hand written to make it extremely fast. This format is used by default popularly libraries like log4j. Roughly this implements following format:yyyy-MM-dd[[' ']['T']HH:mm[':'ss[[.][,]SSSSSSSSS]]]
This is a follow up PR of #11465
Related Issues
Resolves #8361
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.