Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing remaining term query in keyword fields #11639

Closed
wants to merge 2 commits into from
Closed

Fixing remaining term query in keyword fields #11639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa3ac06
Fixing remaining term query in keyword fields
harshavamsi Dec 21, 2023
0065a1e
Fixing assert statements
harshavamsi Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Change error message when per shard document limit is breached ([#11312](https://github.com/opensearch-project/OpenSearch/pull/11312))
- Automatically add scheme to discovery.ec2.endpoint ([#11512](https://github.com/opensearch-project/OpenSearch/pull/11512))
- Restore support for Java 8 for RestClient ([#11562](https://github.com/opensearch-project/OpenSearch/pull/11562))

- Update `termQuery` in KeyWordField to be searchable through `doc_values` ([#11639](https://github.com/opensearch-project/OpenSearch/pull/11639))
### Deprecated

### Removed
Expand Down
13 changes: 10 additions & 3 deletions modules/percolator/src/test/java/org/opensearch/percolator/QueryBuilderStoreTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import org.apache.lucene.index.IndexWriterConfig;
import org.apache.lucene.index.LeafReaderContext;
import org.apache.lucene.index.NoMergePolicy;
import org.apache.lucene.search.IndexOrDocValuesQuery;
import org.apache.lucene.search.Query;
import org.apache.lucene.search.TermQuery;
import org.apache.lucene.store.Directory;
Expand Down Expand Up @@ -121,9 +122,15 @@ public void testStoringQueryBuilders() throws IOException {
CheckedFunction<Integer, Query, IOException> queries = queryStore.getQueries(leafContext);
assertEquals(queryBuilders.length, leafContext.reader().numDocs());
for (int i = 0; i < queryBuilders.length; i++) {
TermQuery query = (TermQuery) queries.apply(i);
assertEquals(queryBuilders[i].fieldName(), query.getTerm().field());
assertEquals(queryBuilders[i].value(), query.getTerm().text());
TermQuery termQuery;
if (fieldMapper.fieldType().typeName().equals("binary")) {
IndexOrDocValuesQuery query = (IndexOrDocValuesQuery) queries.apply(i);
termQuery = (TermQuery) query.getIndexQuery();
} else {
termQuery = (TermQuery) queries.apply(i);
}
assertEquals(queryBuilders[i].fieldName(), termQuery.getTerm().field());
assertEquals(queryBuilders[i].value(), termQuery.getTerm().text());
}
}
}
Expand Down
Loading
Loading