Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulate remove ingest processor throwing illegal_argument_exception #11607

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Dec 13, 2023

Description

This PR fixes the bug of simulating remove ingest processor always throwing illegal_argument_exception, the bug is caused by the new merged PR which disallowing removing some metadata fields, but when simulating processors, the ingesting document does not have the metadata fields like _version and _version_type, so document.getFieldValue(IngestDocument.Metadata.VERSION_TYPE.getFieldName(), String.class) throws illegal_argument_exception rather than return null value, in order to return null value, use another method instead with setting ignore_missing to true.

Both the unit test code and yml test do not cover this case, I've added some yml tests and unit test code for it.

Related Issues

#11604

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaobinlong
Copy link
Collaborator Author

@reta , could you help to review this PR? Thanks!

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Compatibility status:

Checks if related components are compatible with change 3d29a28

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

✅ Gradle check result for 22d295c: SUCCESS

Copy link
Contributor

❕ Gradle check result for 598c74a: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotWithLargeSegmentFiles
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❕ Gradle check result for 7d90ad6: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❕ Gradle check result for 5968814: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.gcs.GoogleCloudStorageBlobContainerRetriesTests.testWriteLargeBlob

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Gao Binlong <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 2, 2024

❕ Gradle check result for bb39c9b: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Gradle check result for e707b70: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jan 4, 2024

✅ Gradle check result for 3d29a28: SUCCESS

@gaobinlong
Copy link
Collaborator Author

Hi @reta , can this PR be merged now? I've resolved the conflict and now all checks have passed yet.

@reta reta self-requested a review January 4, 2024 13:46
@reta reta added bug Something isn't working v3.0.0 Issues and PRs related to version 3.0.0 v2.12.0 Issues and PRs related to version 2.12.0 labels Jan 4, 2024
@reta reta merged commit f647515 into opensearch-project:main Jan 4, 2024
42 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Jan 4, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 4, 2024
…ion (#11607)

* Fix simulate remove ingest processor throwing illegal_argument_exception

Signed-off-by: Gao Binlong <[email protected]>

* modify change log

Signed-off-by: Gao Binlong <[email protected]>

* Create a new test mothod

Signed-off-by: Gao Binlong <[email protected]>

* Use old method to get field value

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
(cherry picked from commit f647515)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Jan 4, 2024
…ion (#11607) (#11745)

* Fix simulate remove ingest processor throwing illegal_argument_exception



* modify change log



* Create a new test mothod



* Use old method to get field value



---------


(cherry picked from commit f647515)

Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…ion (opensearch-project#11607)

* Fix simulate remove ingest processor throwing illegal_argument_exception

Signed-off-by: Gao Binlong <[email protected]>

* modify change log

Signed-off-by: Gao Binlong <[email protected]>

* Create a new test mothod

Signed-off-by: Gao Binlong <[email protected]>

* Use old method to get field value

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ion (opensearch-project#11607)

* Fix simulate remove ingest processor throwing illegal_argument_exception

Signed-off-by: Gao Binlong <[email protected]>

* modify change log

Signed-off-by: Gao Binlong <[email protected]>

* Create a new test mothod

Signed-off-by: Gao Binlong <[email protected]>

* Use old method to get field value

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working v2.12.0 Issues and PRs related to version 2.12.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants