-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix simulate remove ingest processor throwing illegal_argument_exception #11607
Conversation
@reta , could you help to review this PR? Thanks! |
Compatibility status:Checks if related components are compatible with change 3d29a28 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
modules/ingest-common/src/test/java/org/opensearch/ingest/common/RemoveProcessorTests.java
Show resolved
Hide resolved
❕ Gradle check result for 598c74a: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❕ Gradle check result for 7d90ad6: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Gao Binlong <[email protected]>
7d90ad6
to
5968814
Compare
❕ Gradle check result for 5968814: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Gao Binlong <[email protected]>
❕ Gradle check result for bb39c9b: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❌ Gradle check result for e707b70: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Hi @reta , can this PR be merged now? I've resolved the conflict and now all checks have passed yet. |
…ion (#11607) * Fix simulate remove ingest processor throwing illegal_argument_exception Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> * Create a new test mothod Signed-off-by: Gao Binlong <[email protected]> * Use old method to get field value Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit f647515) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ion (#11607) (#11745) * Fix simulate remove ingest processor throwing illegal_argument_exception * modify change log * Create a new test mothod * Use old method to get field value --------- (cherry picked from commit f647515) Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ion (opensearch-project#11607) * Fix simulate remove ingest processor throwing illegal_argument_exception Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> * Create a new test mothod Signed-off-by: Gao Binlong <[email protected]> * Use old method to get field value Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]>
…ion (opensearch-project#11607) * Fix simulate remove ingest processor throwing illegal_argument_exception Signed-off-by: Gao Binlong <[email protected]> * modify change log Signed-off-by: Gao Binlong <[email protected]> * Create a new test mothod Signed-off-by: Gao Binlong <[email protected]> * Use old method to get field value Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR fixes the bug of simulating remove ingest processor always throwing illegal_argument_exception, the bug is caused by the new merged PR which disallowing removing some metadata fields, but when simulating processors, the ingesting document does not have the metadata fields like
_version
and_version_type
, sodocument.getFieldValue(IngestDocument.Metadata.VERSION_TYPE.getFieldName(), String.class)
throws illegal_argument_exception rather than return null value, in order to return null value, use another method instead with settingignore_missing
totrue
.Both the unit test code and yml test do not cover this case, I've added some yml tests and unit test code for it.
Related Issues
#11604
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.