-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Introduce cluster level setting cluster.index.restrict.replication.type
to prevent replication type setting override during index creations
#11583
Conversation
❌ Gradle check result for 54c4bae: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 722f064: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 948ce3a Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for 2333244: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Suraj Singh <[email protected]>
db7f2d9
to
39d47be
Compare
cluster.force.index.replication.type
to prevent replication type setting override during index creations
@kotwanikunal @andrross : Thanks for the feedback. Addressed the review comments. Please have a look. |
❕ Gradle check result for 39d47be: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
...lClusterTest/java/org/opensearch/indices/replication/SegmentReplicationClusterSettingIT.java
Outdated
Show resolved
Hide resolved
...lClusterTest/java/org/opensearch/indices/replication/SegmentReplicationClusterSettingIT.java
Outdated
Show resolved
Hide resolved
...lClusterTest/java/org/opensearch/indices/replication/SegmentReplicationClusterSettingIT.java
Outdated
Show resolved
Hide resolved
cluster.force.index.replication.type
to prevent replication type setting override during index creationscluster.index.restrict.replication.type
to prevent replication type setting override during index creations
Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
@andrross @kotwanikunal : Addressed review comments. Please have a look. |
❕ Gradle check result for 81d63ba: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❌ Gradle check result for 46c530d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Suraj Singh <[email protected]>
❌ Gradle check result for 46c530d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 948ce3a: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Looks good to me. @kotwanikunal what do you think? |
LGTM. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11583-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a6ab32e532d16de222645ccfae376c778c68991
# Push it to GitHub
git push --set-upstream origin backport/backport-11583-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…restrict.replication.type` to prevent replication type setting override during index creations (opensearch-project#11583) * Add new cluster level setting that prevents index level replication type setting overrides Signed-off-by: Suraj Singh <[email protected]> * Block restore on mis-matching replication type setting Signed-off-by: Suraj Singh <[email protected]> * Address review comments and rebase Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Use appropriate variable names Signed-off-by: Suraj Singh <[email protected]> * Fix failing integ test Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit 6a6ab32)
…estrict.replication.type` to prevent replication type setting override during index creations (#11583) (#11707) * [Segment Replication] Introduce cluster level setting `cluster.index.restrict.replication.type` to prevent replication type setting override during index creations (#11583) * Add new cluster level setting that prevents index level replication type setting overrides Signed-off-by: Suraj Singh <[email protected]> * Block restore on mis-matching replication type setting Signed-off-by: Suraj Singh <[email protected]> * Address review comments and rebase Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Use appropriate variable names Signed-off-by: Suraj Singh <[email protected]> * Fix failing integ test Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit 6a6ab32) * Remove duplicate IndicesService.CLUSTER_REMOTE_INDEX_RESTRICT_ASYNC_DURABILITY_SETTING setting introduce from conflict resolution Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]>
…restrict.replication.type` to prevent replication type setting override during index creations (opensearch-project#11583) * Add new cluster level setting that prevents index level replication type setting overrides Signed-off-by: Suraj Singh <[email protected]> * Block restore on mis-matching replication type setting Signed-off-by: Suraj Singh <[email protected]> * Address review comments and rebase Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Use appropriate variable names Signed-off-by: Suraj Singh <[email protected]> * Fix failing integ test Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]>
…restrict.replication.type` to prevent replication type setting override during index creations (opensearch-project#11583) * Add new cluster level setting that prevents index level replication type setting overrides Signed-off-by: Suraj Singh <[email protected]> * Block restore on mis-matching replication type setting Signed-off-by: Suraj Singh <[email protected]> * Address review comments and rebase Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Use appropriate variable names Signed-off-by: Suraj Singh <[email protected]> * Fix failing integ test Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Introduces node level cluster setting
cluster.index.restrict.replication.type
to restrict setting replication type setting at index levelRelated Issues
Resolves ##11457
Documentation Issue
opensearch-project/documentation-website#5806
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.