Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote snapshot index supports aliases #11226

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arvinsg
Copy link

@arvinsg arvinsg commented Nov 16, 2023

Description

[Describe what this change achieves]

We want to add support for searchable snapshots within index management which can operate as follows :

  • Take a snapshot for the index
  • Rename on restore the index as a searchable snapshot index
  • Swaps all the aliases from the source index to the restored index and deletes the source index

But found that aliases operation is blocked by REMOTE_READ_ONLY_ALLOW_DELETE cluster block. In order to switch the index smoothly, We hope that the searchable snapshot index supports aliases operation.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Compatibility status:

Checks if related components are compatible with change 7ebf516

Incompatible components

Incompatible components: [https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for 63e4a51: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

Thanks @arvinsg! This is definitely a reasonable feature request. Can you add some tests for this feature? Also can you take a look at the failed DCO workflow and properly sign your commits?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Dec 22, 2023
Copy link
Contributor

❌ Gradle check result for cc9a776: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@arvinsg arvinsg force-pushed the feature/remote-index-support-alias branch from cc9a776 to 237ba03 Compare December 27, 2023 11:17
@arvinsg
Copy link
Author

arvinsg commented Dec 27, 2023

Thanks @arvinsg! This is definitely a reasonable feature request. Can you add some tests for this feature? Also can you take a look at the failed DCO workflow and properly sign your commits?

@andrross Add some test cases, thanks for the advice and review

Copy link
Contributor

❌ Gradle check result for 237ba03: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jan 3, 2024
Signed-off-by: songguoliang <[email protected]>
Copy link
Contributor

❌ Gradle check result for 7ebf516: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Feb 21, 2024
@sandervandegeijn
Copy link

This would be fantastic, following :)

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Mar 17, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants