-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Numeric exact match queries to use range queries internally #11209
Fixes Numeric exact match queries to use range queries internally #11209
Conversation
❌ Gradle check result for 6a324a4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 339a681 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for 443e205: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 36708f8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
36708f8
to
d97865e
Compare
❌ Gradle check result for d97865e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bbd4e4e
to
1289b3e
Compare
❌ Gradle check result for bbd4e4e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 1289b3e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 27f4e47: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for c5acd4c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11209 +/- ##
============================================
- Coverage 71.44% 70.90% -0.54%
+ Complexity 59267 58864 -403
============================================
Files 4909 4911 +2
Lines 278427 278651 +224
Branches 40460 40524 +64
============================================
- Hits 198910 197585 -1325
- Misses 63004 64661 +1657
+ Partials 16513 16405 -108 ☔ View full report in Codecov by Sentry. |
Gradle failure is flaky test -- #5329 |
❌ Gradle check result for 430310a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
430310a
to
b54a539
Compare
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
❌ Gradle check result for b54a539: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@harshavamsi please rebase against latest |
❕ Gradle check result for ebba45f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
@msfroh could you please take a look? (waiting for your signoff) thank you |
Just a residual merge conflict on the changelog, where you picked up a couple of other changes. Otherwise, it looks good to me 👍 |
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Thanks @msfroh, fixed the changelog. |
❌ Gradle check result for 339a681: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 339a681: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…1209) * Updating numeric term and terms queries to use IODVQ Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Addressing comments Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix formatting Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix changelog Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Addressing more comments + adding tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * renaming yaml test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding skip for bwc Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding new SortedUnsignedLongDocValuesSetQuery to allow for BitInteger Terms query Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fixing some tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Remove duplicate skip Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Remove unused points declaration Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Change unsigned exact query to be consistent Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Use slowExactQuery from Unsigned Set Query Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Merging different yaml tests into a single test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Updating test case for main Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix changelog Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> (cherry picked from commit 178a7a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…1209) (#11747) * Updating numeric term and terms queries to use IODVQ * Addressing comments * Fix formatting * Fix changelog * Addressing more comments + adding tests * renaming yaml test * Adding skip for bwc * Adding new SortedUnsignedLongDocValuesSetQuery to allow for BitInteger Terms query * Fixing some tests * Remove duplicate skip * Remove unused points declaration * Change unsigned exact query to be consistent * Use slowExactQuery from Unsigned Set Query * Merging different yaml tests into a single test * Updating test case for main * Fix changelog --------- (cherry picked from commit 178a7a0) Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ensearch-project#11209) * Updating numeric term and terms queries to use IODVQ Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Addressing comments Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix formatting Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix changelog Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Addressing more comments + adding tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * renaming yaml test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding skip for bwc Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding new SortedUnsignedLongDocValuesSetQuery to allow for BitInteger Terms query Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fixing some tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Remove duplicate skip Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Remove unused points declaration Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Change unsigned exact query to be consistent Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Use slowExactQuery from Unsigned Set Query Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Merging different yaml tests into a single test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Updating test case for main Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix changelog Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
…ensearch-project#11209) * Updating numeric term and terms queries to use IODVQ Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Addressing comments Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix formatting Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix changelog Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Addressing more comments + adding tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * renaming yaml test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding skip for bwc Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding new SortedUnsignedLongDocValuesSetQuery to allow for BitInteger Terms query Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fixing some tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Remove duplicate skip Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Remove unused points declaration Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Change unsigned exact query to be consistent Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Use slowExactQuery from Unsigned Set Query Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Merging different yaml tests into a single test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Updating test case for main Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix changelog Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Updates term and terms queries for numeric fields to use IndexOrDocValues where appropriate.
Related Issues
Resolves #11097
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.