[Remove] Remaining Joda and Joda Dependency #10949
Conversation
nknize
added
pending backport
nknize
requested review from
abbashus,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
peternied,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 5599d3e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Joda was deprecated in Elasticsearch 7.x. OpenSearch should have proactively removed in 2.0. This commit removes the remaining Joda dependency and formatting logic in favor of java 8 time. It adds a new LegacyFormat class, however, to ensure camelCase DateFormat is supported for indexes created in ElasticSearch 7.x (and carried through OpenSearch 1.x). Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
| @@ -325,7 +325,8 @@ private void init(FieldMapper toInit) { | |||
| setValue(initializer.apply(toInit)); | |||
| } | |||
|
|
|||
| private void parse(String field, ParserContext context, Object in) { | |||
| // public for testing only | |||
| public void parse(String field, ParserContext context, Object in) { | |||
There was a problem hiding this comment.
This visibility change seems to be not needed, what test needs it?
github-actions
bot
added
dependencies
|
This PR is stalled because it has been open for 30 days with no activity. |
opensearch-trigger-bot
bot
added
stalled
|
Hi @nknize, the PR is stalled. Is this being worked upon? |
|
These PRs have been ready for review / approval for quite a while. Either no one has been comfortable approving them or everyone is busy with their own tasks. I'll rebase when there's a need (approval or change) otherwise I'll be rebasing in perpetuity. |
To be fair, @reta reviewed it on November 13th, asked a question and got no reply. |
nknize
added
feedback needed
|
This PR is stalled because it has been open for 30 days with no activity. |
opensearch-trigger-bot
bot
added
stalled
|
This PR is stalled because it has been open for 30 days with no activity. |
opensearch-trigger-bot
bot
added
stalled
|
This PR is stalled because it has been open for 30 days with no activity. |
|
won't be actively working unless needed |
Joda was deprecated in Elasticsearch 7.x. OpenSearch should have proactively removed in 2.0. This PR removes the remaining Joda dependency and formatting logic in favor of java 8 time. It adds a new
LegacyFormatNameclass, however, to ensure camelCase DateFormat is supported for indexes created in ElasticSearch 7.x (and carried through OpenSearch 1.x).relates #5910
relates #8110
Closes #3995