-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix valid cluster UUID logic for uncommitted cluster UUIDs #10916
Fix valid cluster UUID logic for uncommitted cluster UUIDs #10916
Conversation
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Show resolved
Hide resolved
Compatibility status:Checks if related components are compatible with change c6cb296 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Can we add an integ test for this? maybe in a followup?
|
4c046be
to
4a80235
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
4a80235
to
87a5e57
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sooraj Sinha <[email protected]>
87a5e57
to
c6cb296
Compare
Gradle Check (Jenkins) Run Completed with:
|
746ca09
into
opensearch-project:main
Signed-off-by: Sooraj Sinha <[email protected]> (cherry picked from commit 746ca09) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…10944) (cherry picked from commit 746ca09) Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…h-project#10916) Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
When the condition that cluster UUID should be committed and it should be not be pointed to by any cluster UUIDs are applied simultaneously, it might skip all the cluster UUIDs. This can happen in case the last cluster UUID in a chain was uncommitted like below:
So we need to first apply the condition of cluster UUID should be committed then reconstruct the graph and then apply the condition of clusterUUID not being pointed to by any cluster UUID.
Related Issues
#10911
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.