-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom metadata not getting stored for remote store not supporting async write #10812
Fix custom metadata not getting stored for remote store not supporting async write #10812
Conversation
…g async write Signed-off-by: Dhwanil Patel <[email protected]>
Compatibility status:Checks if related components are compatible with change f41dc14 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10812 +/- ##
=========================================
Coverage 71.31% 71.31%
- Complexity 58671 58673 +2
=========================================
Files 4860 4860
Lines 276335 276338 +3
Branches 40198 40198
=========================================
+ Hits 197068 197073 +5
- Misses 62803 62843 +40
+ Partials 16464 16422 -42
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e618b9b
into
opensearch-project:main
…g async write (#10812) Signed-off-by: Dhwanil Patel <[email protected]> (cherry picked from commit e618b9b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…g async write (#10812) (#10828) (cherry picked from commit e618b9b) Signed-off-by: Dhwanil Patel <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…g async write (opensearch-project#10812) Signed-off-by: Dhwanil Patel <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Fix custom metadata not getting stored for remote store not supporting async write.
Related Issues
#10691
#10697
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.