Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom metadata not getting stored for remote store not supporting async write #10812

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

dhwanilpatel
Copy link
Contributor

Description

Fix custom metadata not getting stored for remote store not supporting async write.

Related Issues

#10691
#10697

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change f41dc14

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #10812 (f41dc14) into main (51626d0) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main   #10812   +/-   ##
=========================================
  Coverage     71.31%   71.31%           
- Complexity    58671    58673    +2     
=========================================
  Files          4860     4860           
  Lines        276335   276338    +3     
  Branches      40198    40198           
=========================================
+ Hits         197068   197073    +5     
- Misses        62803    62843   +40     
+ Partials      16464    16422   -42     
Files Coverage Δ
...arch/gateway/remote/RemoteClusterStateService.java 69.80% <100.00%> (+0.06%) ⬆️
...epositories/blobstore/ChecksumBlobStoreFormat.java 95.16% <100.00%> (+0.16%) ⬆️

... and 449 files with indirect coverage changes

Copy link
Collaborator

@linuxpi linuxpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shwetathareja shwetathareja merged commit e618b9b into opensearch-project:main Oct 22, 2023
43 of 69 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Oct 22, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 22, 2023
…g async write (#10812)

Signed-off-by: Dhwanil Patel <[email protected]>
(cherry picked from commit e618b9b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Oct 22, 2023
…g async write (#10812) (#10828)

(cherry picked from commit e618b9b)

Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants