Adding access to noSubMatches and noOverlappingMatches

[evankielley]

…CompoundWordTokenFilter

Description

This change adds support for / exposes two new settings (noSubMatches and noOverlappingMatches) that were added to Lucene's HyphenationCompoundWordTokenFilter class.

Related Issues

Resolves #8796

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[evankielley]

@msfroh I closed my previous pull request #9836 (albeit not intentionally). This PR has the same content, I just need to update the CHANGELOG as well.

[github-actions]

Compatibility status:

Checks if related components are compatible with change 1a22b1b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28506/
• CommitID: 1a22b1b
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[msfroh]

@msfroh I closed my previous pull request #9836 (albeit not intentionally). This PR has the same content, I just need to update the CHANGELOG as well.

Thanks @evankielley!

Can you please also click the link in the PR checklist to create a documentation issue? It looks like we have a list of analyzers with links to the Lucene 8.7 JavaDocs: https://opensearch.org/docs/latest/analyzers/token-filters/index/. We should probably update those links to point to whatever version of Lucene was used for a given release.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28931/
• CommitID: 1a22b1b
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[evankielley]

@msfroh I closed my previous pull request #9836 (albeit not intentionally). This PR has the same content, I just need to update the CHANGELOG as well.

Thanks @evankielley!

Can you please also click the link in the PR checklist to create a documentation issue? It looks like we have a list of analyzers with links to the Lucene 8.7 JavaDocs: https://opensearch.org/docs/latest/analyzers/token-filters/index/. We should probably update those links to point to whatever version of Lucene was used for a given release.

No problem! Issue created here: opensearch-project/documentation-website#5389

[noCharger]

Let's add some test coverage for this change.

[evankielley]

Let's add some test coverage for this change.

It looks like there's no existing unit tests for this class. Should I create a new file for unit tests in modules/analysis-common/src/test/java/org/opensearch/analysis/ or is there some reason why unit tests were skipped for this class in the first place?

[noCharger]

Let's add some test coverage for this change.

It looks like there's no existing unit tests for this class. Should I create a new file for unit tests in modules/analysis-common/src/test/java/org/opensearch/analysis/ or is there some reason why unit tests were skipped for this class in the first place?

One likely reason is that unit testing around the lucene library itself does not add much value, hence it is non-blocking for this PR. There are some good examples on testing just for reference #9479

Let's rebase to fix the gradle check failure https://build.ci.opensearch.org/job/gradle-check/28931/console

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':qa:mixed-cluster:v2.12.0#mixedClusterTest'.
> There were failing tests. See the report at: file:///var/jenkins/workspace/gradle-check/search/qa/mixed-cluster/build/reports/tests/v2.12.0%23mixedClusterTest/index.html

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[ticheng-aws]

Hi @evankielley, Is this being worked upon? Feel free to reach out to maintainers for further reviews.

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[jed326]

Closing stalled PR due to inactivity for over 6 months. Please re-open a new PR if you would still like to submit this change. Thanks!