-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing buffered stream in s3 #10710
Closing buffered stream in s3 #10710
Conversation
40e1a1b
to
c3725ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vikas can we write a test for the same
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/async/AsyncPartsHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vikasvb90
Compatibility status:Checks if related components are compatible with change bd5e7da Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
The failing tests are due to a
I am going to put up a PR for same in some time |
c3725ca
to
efb7e64
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: vikasvb90 <[email protected]>
efb7e64
to
bd5e7da
Compare
Gradle Check (Jenkins) Run Completed with:
|
All the failing tests are due to https://github.com/opensearch-project/OpenSearch/pull/10712/files not merged before this . Going ahead with the merge . |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10710-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7936f94ef6692516c58f4c46a8a3747da9cd9f1d
# Push it to GitHub
git push --set-upstream origin backport/backport-10710-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…nup (opensearch-project#10710) Signed-off-by: vikasvb90 <[email protected]>
…nup (opensearch-project#10710) Signed-off-by: vikasvb90 <[email protected]>
…during IO errors #10690 (#10741) * Added BufferedInputStream to allow mark and reset ops during IO errors (#10690) Signed-off-by: vikasvb90 <[email protected]> (cherry picked from commit 75bd9f2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Added close on buffered stream in s3 async upload for additional cleanup (#10710) Signed-off-by: vikasvb90 <[email protected]> --------- Signed-off-by: vikasvb90 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vikas Bansal <[email protected]>
…nup (opensearch-project#10710) Signed-off-by: vikasvb90 <[email protected]>
…nup (opensearch-project#10710) Signed-off-by: vikasvb90 <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Adding close on buffered stream in s3 async upload for early cleanup of resources.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.