-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Added BufferedInputStream to allow mark and reset ops during IO errors #10698
Conversation
#10690) Signed-off-by: vikasvb90 <[email protected]> (cherry picked from commit 75bd9f2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Compatibility status:Checks if related components are compatible with change 632ba3e Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am blocking this backport till we introduce proper cleanup of the BufferedInputStream
, commented here #10690 (comment)
Gradle Check (Jenkins) Run Completed with:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #10698 +/- ##
============================================
+ Coverage 70.93% 70.97% +0.04%
- Complexity 58575 58611 +36
============================================
Files 4830 4830
Lines 276453 276488 +35
Branches 40588 40591 +3
============================================
+ Hits 196091 196242 +151
+ Misses 63676 63515 -161
- Partials 16686 16731 +45 ☔ View full report in Codecov by Sentry. |
There's also no tests with this change. |
This PR is stalled because it has been open for 30 days with no activity. |
@gbbafna do you want this in 2.x? I am afraid it will need to be done manually |
This PR is stalled because it has been open for 30 days with no activity. |
Hi @gbbafna, this backport PR is stalled. Could you help to take an action or close it. |
@gbbafna Backport is still stalled please take action or close it. Thanks |
This is no longer needed now : #10741 |
Backport 75bd9f2 from #10690.