Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Added BufferedInputStream to allow mark and reset ops during IO errors #10698

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 75bd9f2 from #10690.

#10690)

Signed-off-by: vikasvb90 <[email protected]>
(cherry picked from commit 75bd9f2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 632ba3e

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am blocking this backport till we introduce proper cleanup of the BufferedInputStream, commented here #10690 (comment)

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (e611185) 70.93% compared to head (632ba3e) 70.97%.
Report is 232 commits behind head on 2.x.

Files Patch % Lines
server/src/main/java/org/opensearch/node/Node.java 41.66% 4 Missing and 3 partials ⚠️
.../org/opensearch/repositories/gcs/SocketAccess.java 33.33% 4 Missing ⚠️
...opensearch/repositories/s3/S3RepositoryPlugin.java 0.00% 4 Missing ⚠️
.../org/opensearch/telemetry/OTelTelemetryPlugin.java 55.55% 3 Missing and 1 partial ⚠️
...etry/tracing/listener/TraceableActionListener.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #10698      +/-   ##
============================================
+ Coverage     70.93%   70.97%   +0.04%     
- Complexity    58575    58611      +36     
============================================
  Files          4830     4830              
  Lines        276453   276488      +35     
  Branches      40588    40591       +3     
============================================
+ Hits         196091   196242     +151     
+ Misses        63676    63515     -161     
- Partials      16686    16731      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock
Copy link
Member

dblock commented Oct 24, 2023

There's also no tests with this change.

@opensearch-trigger-bot
Copy link
Contributor Author

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Nov 24, 2023
@dblock
Copy link
Member

dblock commented Nov 26, 2023

@gbbafna do you want this in 2.x? I am afraid it will need to be done manually

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Nov 27, 2023
@opensearch-trigger-bot
Copy link
Contributor Author

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jan 5, 2024
@ticheng-aws
Copy link
Contributor

Hi @gbbafna, this backport PR is stalled. Could you help to take an action or close it.

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jan 7, 2024
@deshsidd
Copy link
Contributor

@gbbafna Backport is still stalled please take action or close it. Thanks

@gbbafna
Copy link
Collaborator

gbbafna commented Jan 13, 2024

This is no longer needed now : #10741

@gbbafna gbbafna closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants