Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR-9107 to make search.concurrent.max_slice_count setting dy… #10606

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

sohami
Copy link
Collaborator

@sohami sohami commented Oct 13, 2023

Description

Backporting changes made in main for #9107 as lucene is upgraded to 9.8 in 2.x branch

Related Issues

Resolves #9108

Check List

  • [] New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT:
  • URL:
  • CommitID: af68cf7
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT:
  • URL:
  • CommitID: 7770b56
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Compatibility status:

Checks if related components are compatible with change f123369

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…namic with lucene-9.8

Signed-off-by: Sorabh Hamirwasia <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sohami !

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #10606 (f123369) into 2.x (52018ec) will increase coverage by 0.00%.
Report is 1 commits behind head on 2.x.
The diff coverage is 57.14%.

@@            Coverage Diff            @@
##                2.x   #10606   +/-   ##
=========================================
  Coverage     70.84%   70.85%           
- Complexity    58489    58503   +14     
=========================================
  Files          4831     4830    -1     
  Lines        276413   276409    -4     
  Branches      40581    40581           
=========================================
+ Hits         195822   195844   +22     
+ Misses        63872    63870    -2     
+ Partials      16719    16695   -24     
Files Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
server/src/main/java/org/opensearch/node/Node.java 85.69% <ø> (-0.02%) ⬇️
...main/java/org/opensearch/search/SearchService.java 72.72% <100.00%> (+0.16%) ⬆️
...ensearch/search/internal/ContextIndexSearcher.java 73.37% <100.00%> (ø)
...search/search/internal/MaxTargetSliceSupplier.java 92.30% <100.00%> (ø)
.../org/opensearch/search/internal/SearchContext.java 41.50% <ø> (ø)
...nsearch/search/internal/FilteredSearchContext.java 8.69% <0.00%> (-0.08%) ⬇️
...va/org/opensearch/search/DefaultSearchContext.java 77.41% <33.33%> (-0.48%) ⬇️

... and 484 files with indirect coverage changes

@reta reta added the v2.12.0 Issues and PRs related to version 2.12.0 label Oct 13, 2023
@reta reta merged commit 28f6788 into opensearch-project:2.x Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants